Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

when using external methods that returns an empty hash, incorrect SQL is generated #20

Closed
ohadlevy opened this issue Mar 8, 2012 · 3 comments

Comments

@ohadlevy
Copy link
Contributor

ohadlevy commented Mar 8, 2012

using the following definition

scoped_search :in => :search_parameters, :on => :value, :on_key=> :name, :complete_value => true, :rename => :params, :ext_method => :search_by_params, :only_explicit => true


def search_by_params method 
  {}
end

and while combining the search query with another query, the resulting query is something like

LINE 1: ...(("something"."name" = 'xxx') AND ())) ORDER ...

@wvanbergen
Copy link
Owner

@abenari Any ideas about this?

abenari added a commit to abenari/scoped_search that referenced this issue Apr 30, 2012
@abenari
Copy link
Collaborator

abenari commented Apr 30, 2012

fixed in commit c16d385
will be included in next release 2.3.7

@abenari abenari closed this as completed Apr 30, 2012
@wvanbergen
Copy link
Owner

Nice work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants