Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eoPred release #17

Open
wvictor14 opened this issue Feb 20, 2023 · 3 comments
Open

eoPred release #17

wvictor14 opened this issue Feb 20, 2023 · 3 comments

Comments

@wvictor14
Copy link
Owner

add @iciarfernandez preeclampsia predictor

Address #16 #11

@wvictor14 wvictor14 changed the title v1.4.0 release v1.7.1 release Mar 18, 2023
@wvictor14
Copy link
Owner Author

wvictor14 commented Mar 18, 2023

todo:

  • create tests
  • expected output
  • documentation

@wvictor14
Copy link
Owner Author

wvictor14 commented Mar 18, 2023

saving model with usethis::use_data(mod) results in a 409 mb .rda file.

which will make package size over 5mb limit of bioconductor

I think easiest option is to make an experimenthub data package to host the model. But we can create functions here to work with the model object (apply predict, and curate results, plot etc.)

Some example data packages:

https://github.com/crisprVerse/crisprScoreData
https://bioconductor.org/packages/release/data/experiment/
https://bioconductor.org/packages/release/data/experiment/html/preciseTADhub.html

@wvictor14
Copy link
Owner Author

wvictor14 commented Mar 23, 2023

@iciarfernandez :

  • predictPreeclampsia - throw error if missing cpgs
  • vignette
  • devtools::check()
  • BiocCheck()
  • fix errors + warnings, notes are ok

@wvictor14

@wvictor14 wvictor14 changed the title v1.7.1 release eoPred release Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

1 participant