Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ethnicity labels #21

Open
wvictor14 opened this issue Aug 11, 2023 · 2 comments
Open

Ethnicity labels #21

wvictor14 opened this issue Aug 11, 2023 · 2 comments

Comments

@wvictor14
Copy link
Owner

          One more thing - it was discussed at lab meeting that instead of `Ambiguous`, it should say `Other` in the labels that `predictEthnicity` outputs, since the tool can only calculate 3 ancestries but there are other ancestries out there (+ ancestry is a continuum) so in reality samples being called ambiguous may just be mixed or from an ancestry other than African/Asian/European. Let me know what you think and if you agree I'm happy to change that myself too!

Originally posted by @iciarfernandez in #19 (comment)

@wvictor14
Copy link
Owner Author

Hey Iciar, so the "amibguous" class is for samples with uncertain predictions, where "uncertain" is defined at some probability cutoff (75% as default). In my paper I show these samples below this threshold to correlate well with mixed genetic ancestry of the three reference ancestries. Because of this, I think "ambiguous" would be better changed to something like "mixed" .

The ethnicity predictor has no way of telling if the queried data is not any of the 3 ancestries used in training data, so I think calling it "other" would be too assumptive and sometimes just wrong.

@iciarfernandez
Copy link
Collaborator

That makes sense to me! I think "mixed" is an improvement from "ambiguous" anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants