Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not possible to set external player for ISO files by default #24861

Open
1 of 7 tasks
Solarunit opened this issue Mar 18, 2024 · 1 comment
Open
1 of 7 tasks

Not possible to set external player for ISO files by default #24861

Solarunit opened this issue Mar 18, 2024 · 1 comment
Labels
Triage: Needed (managed by bot!) issue that was just created and needs someone looking at it

Comments

@Solarunit
Copy link

Solarunit commented Mar 18, 2024

Bug report

Describe the bug

Not possible to set external player for ISO files by default.
I have tried different rules combinations to force play ISO files with external player but internal VideoPlayer is always selected as default one.
I can select external player to play ISO files from the Play Using context menu and it works.

My rules examples:

<rule name="dvdimage" dvdimage="true" player="my-player" />
<rule name="iso" filetypes="iso|ISO" player="my-player"/>

Here is kodi log:

debug <general>: CPlayerSelectionRule::GetPlayers: matches rule: discimage
debug <general>: CPlayerSelectionRule::GetPlayers: adding player: VideoPlayer for rule: discimage

Kodi adds VideoPlayer as default one.

Expected Behavior

External player should be default player when it was set to play ISO files in the playercorefactory.

Actual Behavior

VideoPlayer as set to be default player instead of external player.

Possible Fix

  • maybe there is a way to disable system rule (for discimage) or override it?
  • force external player rule for ISO files

To Reproduce

Steps to reproduce the behavior:

  1. Set rule for ISO files to play them in external player (or script)
  2. Play ISO file
  3. See in kodi logs that VideoPlayer is set as default player

Debuglog

Here is kodi log:

debug <general>: CPlayerSelectionRule::GetPlayers: matches rule: discimage
debug <general>: CPlayerSelectionRule::GetPlayers: adding player: VideoPlayer for rule: discimage

Kodi adds VideoPlayer as default one.

Your Environment

Used Operating system:

  • Android

  • iOS

  • tvOS

  • Linux

  • macOS

  • Windows

  • Windows UWP

  • Operating system version/name: Solus

  • Kodi version: Kodi 20.5 flatpak

@xbmc-gh-bot xbmc-gh-bot bot added the Triage: Needed (managed by bot!) issue that was just created and needs someone looking at it label Mar 18, 2024
@Solarunit
Copy link
Author

Solarunit commented Mar 18, 2024

found related issue #15841

If this rule is disabled in /system/playercorefactory.xml :

<rule name="discimage" discimage="true" game="false" player="VideoPlayer" />

https://github.com/xbmc/xbmc/blob/master/system/playercorefactory.xml#L29

then external player can play ISO files by default.

VideoPlayer is also listed in the Play using menu and can play ISO file too.

I assume that /system/playercorefactory.xml file would be overwritten on the any next Kodi update, so this is a bad workaround.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Triage: Needed (managed by bot!) issue that was just created and needs someone looking at it
Projects
None yet
Development

No branches or pull requests

1 participant