Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GUIFontTTF] Fix regressions on centered GUI text #25163

Merged
merged 2 commits into from May 9, 2024

Conversation

CastagnaIT
Copy link
Collaborator

Description

fixes a couple of regressions caused by #24799
this is noticeable on kodi splash screen

1 problem was on maxPixelWidth where was missing a condition to avoid consider 0 value (disabled)
2 problem tab chars was resetting the textWidth calculation

BEFORE:
Pr1_Before
AFTER:
Pr1_After

BEFORE WITH TAB:
Pr2_Before
AFTER WITH TAB:
Pr2_After

Motivation and context

fix #25155

How has this been tested?

What is the effect on users?

Screenshots (if appropriate):

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • Student submission (PR was done for educational purposes and will be treated as such)
  • None of the above (please explain below)

Checklist:

  • My code follows the Code Guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the Contributing document
  • I have added tests to cover my change
  • All new and existing tests passed

@CastagnaIT CastagnaIT added this to the "P" 22.0 Alpha 1 milestone May 8, 2024
@CastagnaIT CastagnaIT requested a review from CrystalP May 8, 2024 11:31
Copy link
Contributor

@CrystalP CrystalP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fuzzard fuzzard merged commit e56e40c into xbmc:master May 9, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Splash screen text not centered
3 participants