-
-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[addons] allow skins etc. to be activated via info dialog #7703
Conversation
In case an addon is already in use it would be nice to alter the button label instead of just disabling it. I also think |
First part's a great idea:), but I'm not sure 'Set as default' would make sense here. (I'm not sure what any of it has to do with the "default" actually). E.g when you select a skin in the settings you select the skin you want to use, you don't select the skin you want to have as default.. Makes sense? |
Well, if you select one of those addons it will become the default for the given section (eg. weather, skin, webif etc). Let's see what the others think about it. |
I agree with tamland that "set as default" doesnt really make sense in this context. Perhaps "Select", "Choose", "Set" or "Apply"? |
"Choose" sounds good to me and the label is already there. |
So are we going with Choose and Chosen(?). I'm going to need two labels, like Use / In use, not just one. |
9354a5c
to
243db69
Compare
On second thought, having the disabled label show the state looks really weird. It's barely visible and not clear at all that it shows actual information. No other buttons does this. E.g "Update" is just disabled if it's already up-to-date. I've done what I think works best here. It now shows Open, Run or Use depending on the type. Any objections to that? |
Needs rebase. Could you please add some screenshots to make easier? |
243db69
to
356f969
Compare
Rebased. I'm not sure what you want me to take screenshot of though @mkortstiege All it does is change the label of the "launch" button depending on the addon type. If not applicable it's disabled, like the current launch button. |
concept sounds ok to me. |
Could you please add some doxy so it's clear what's the difference between |
356f969
to
699b35f
Compare
699b35f
to
87e6e24
Compare
done. jenkins build and merge |
Allows addons that can only have one in use at a time (skins, gui sounds, languages, visualization and screensavers) to be "activated" in the addon info dialog without having to dig through settings.
Reuses the "launch" button for plugins.