Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem resizing with containment #159

Closed
RaananW opened this issue Apr 30, 2019 · 3 comments · Fixed by #165
Closed

Problem resizing with containment #159

RaananW opened this issue Apr 30, 2019 · 3 comments · Fixed by #165
Labels
bug

Comments

@RaananW
Copy link
Contributor

RaananW commented Apr 30, 2019

Hi,

Thanks for a great plugin :-)
I am having a problem, which i thought is due to my setup, but then i found out it is also present in the example page. Here is a quick screencast:
Angular2DraggableDemo - Edited

There are two problems presented here:

  1. The left / width values keep on bouncing when on the lower edge of the container
  2. The right side of the container doesn't stop from resizing.

It seems to be related to the checkBounds function and the correlation to origSize, but i still haven't found the concrete reason. Any idea how to fix this?
@xieziyu
Copy link
Owner

xieziyu commented May 5, 2019

Thanks for reporting this issue. I will look into it.

@xieziyu xieziyu added the bug label May 5, 2019
xieziyu pushed a commit that referenced this issue May 14, 2019
fix issue: resizing with containment #159
5725a1f
xieziyu pushed a commit that referenced this issue May 14, 2019
Release v2.3.0
0d55ffa 
## 2.3.0 (2019-05-14)

#### New
+ **ngDraggable**: Add CSS class `ng-dragging` when dragging.
+ **ngResizable**: Add `direction` property in `IResizeEvent`.

#### Bugfix
+ **ngResizable**: Fix [issue #157](#159): Problem resizing with containment
@xieziyu xieziyu mentioned this issue May 14, 2019
Merged
@RaananW
Copy link
Contributor Author

RaananW commented May 14, 2019

Amazing, thanks a lot for a quick fix!

@dioseltorre
Copy link

I found the same issue but using nw and sw handles. This is using the latest version (2.3.0) as of this writing.
As you can see below:

screen-capture-3

@dioseltorre dioseltorre mentioned this issue May 22, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Release v2.3.0 xieziyu/angular2-draggable
3 participants
@RaananW @xieziyu @dioseltorre