Message type 'direct' is non-standard

[michaelansel]

As of OpenFire 3.10.2, messages with type 'direct' are considered invalid and any client attempting to send one is immediately disconnected. I can't figure out why this behavior changed (we upgraded from 3.8.2), but reading through the spec, a message with type 'direct' never should have worked in the first place. Instead, 1-to-1 messages should use the message type 'chat'.

• Update documentation to always recommend message type 'chat'
• Emit a warning if message type 'direct' (or any other invalid type) is used
• Add a sendPrivateMessage function that abstracts away this weirdness

XMPP Message Types: http://xmpp.org/rfcs/rfc3921.html#stanzas-message-type

[michaelansel]

I'll start working on patches as soon as I have a chance...

[markstory]

Neat, I built the original code using ejabberd. Interesting that the two popular xmpp servers both implemented the nonstandard message type in the same way.