You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When pages of different sizes are layout in multiple rows, pages are not aligned as they should (there is some padding missing on the more narrow pages).
Additionally they are not centered vertically.
Expected Behaviour
All layout grid cells should be aligned, and pages should be centered horizontally and vertically within them.
Steps to Reproduce
Set layout to 3-4 columns
Open a document with different page sizes, eg. my beautiful physics notes
Additional Context
I have a fix ready. Looks like this:
I know that horizontal alignement and vertical centering are kind of separate issues but I think it looks much nicer like this.
PR incoming
The text was updated successfully, but these errors were encountered:
I've been thinking about how this should best be solved. I suggest an option to choose between "grid" and "constant padding". I sketched how that would look. If someone could maybe give some feedback before I try to implement it all, it'd be greatly appreciated. Layout.pdf
Note: page ordering would of course change between horizontal and vertical layout. I haven't depicted that accurately.
Operating System
Linux
(Linux only) Distribution
openSUSE Tumbleweed
(Linux only) Desktop Environment
KDE Plasma
(Linux Only) Display Server
Wayland
Installation Method
Build from source
Xournal++ Version
xournalpp 1.2.1+dev (889aefd3)
libgtk Version
libgtk: 3.24.38
Bug Description
When pages of different sizes are layout in multiple rows, pages are not aligned as they should (there is some padding missing on the more narrow pages).
Additionally they are not centered vertically.
Expected Behaviour
All layout grid cells should be aligned, and pages should be centered horizontally and vertically within them.
Steps to Reproduce
Additional Context
I have a fix ready. Looks like this:
I know that horizontal alignement and vertical centering are kind of separate issues but I think it looks much nicer like this.
PR incoming
The text was updated successfully, but these errors were encountered: