Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using the "Twig_Extension" class is deprecated since Twig version 2.7 #38

Open
poaq opened this issue May 4, 2020 · 2 comments
Open

Comments

@poaq
Copy link

poaq commented May 4, 2020

any plan to update it?

solution:
Twig\Extension\AbstractExtension intsead of twig_extension
Twig\TwigFunction instead of Twig_SimpleFunction

create yaml file for config: google_tag_manager.yaml (this info is lack in docs)

@jkabat
Copy link
Contributor

jkabat commented Feb 8, 2021

@xyNNN would update of twig classes be accepted? That means dropping support for old symphony versions and allow Twig v3.

@xyNNN
Copy link
Owner

xyNNN commented Feb 8, 2021

@jkabat

We can drop it, sure. My suggestion is to update twig as dependency and create a new major release (3.x) for the new Symfony version, so we can support the old versions with the 2.x release. Feel free to make a pull request 👍 Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants