-
-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Including a subdir path in the output path for panelize should create the directory if it doesn't exist #526
Comments
I am unsure if this is a wanted behavior or not. Consider the user invokes KiKit with What might be more appropriate is to add a flag (just like |
You could output a message to the terminal when the new dir is created, that way if the file isn't where the user expected it to be, due to a typo, they would see in the terminal that a new dir was created to put them in. You could do the same for fab too, so the user knows where to look if it's the first time they're running the command :) |
Outputting a message is not much in the spirit of automation. When something probably unexpected should happen, we should fail. Only when we fail we should output anything (e.g., a hint to rerun the command with a flag). |
Yes understood, that's fair. Equally though, in the spirit of automation, I'd expect the output directory to be created if it doesn't exist. As it is, the following is printed to the console:
Which is a bit confusing given that I wouldn't expect it to be reading the output file, it should be creating it. In the spirit of convention over configuration the convention is to create output files/ paths if they don't exist, rather than requiring an additional configuration parameter be set. That's what I expected with All that said, it's your software so I'm totally happy if you close the issue as invalid and I'll write a shell script to wrap the call to kikit to create the directory if it doesn't exist. |
Prerequisites
Description
Currently, if I run the command
the command fails if the
panels
subdir doesn't already exist. It would be nice if the directory could be created automatically, as it is with the output directory forkikit fab
.The reason for including a path in the panelization output is that it keeps things tidy when creating multiple panels, and allows the dir to be excluded from source control if required.
The text was updated successfully, but these errors were encountered: