Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Garbled outline when contour in edge.cuts is not closed #138

Open
cof-celldeg opened this issue Jan 18, 2023 · 1 comment
Open

Garbled outline when contour in edge.cuts is not closed #138

cof-celldeg opened this issue Jan 18, 2023 · 1 comment

Comments

@cof-celldeg
Copy link

cof-celldeg commented Jan 18, 2023

I made a mistake in my board by not closing the contour correcly (line on the bottom-left corner was ending about 1mm short) and this caused PcbDraw plot (fantastic tool!) to generate a visibly deformed contour and a garbled rendering of the PCB. See attached image. I also included the kicad_pcb file with the malformed contour for testing purposes.

I dont believe any other settings are of importance as simply closing the contour fixed the issue.
This error may be hard to spot in the CAD view (nonzero line width occluding mismatching corners).
It should be easily caugh by code. A textual warning when calling pcbdraw plot with such malformed input would be very helpful.

This is possibly related to #108 but as I am using a rather old stable release of KiCAD (6.0.5) I opened a new issue.

PCBDraw_BugReport.zip
bugged_contour

@yaqwsx
Copy link
Owner

yaqwsx commented Nov 5, 2023

I don't want to pollute PcbDraw with (no-so-well working) heuristics for fixing malformed outline. The most I am willing to do is to refuse to plot such board. In this case, even the 3D viewer of KiCAD refuses to draw the board.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants