This repository has been archived by the owner on Mar 26, 2018. It is now read-only.
feat(build): add autoprefixer support #317
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for SASS and vanilla CSS to get automatic vendor prefixes base on the browsers selected in the Gruntfile.
| @@ -16,6 +16,7 @@ | |||
| "grunt-contrib-htmlmin": "~0.1.3", | |||
| "grunt-contrib-imagemin": "~0.1.4", | |||
| "grunt-contrib-watch": "~0.4.0", | |||
| "grunt-autoprefixer": "~0.2.20130806", | |||
There was a problem hiding this comment.
i know it's correct, but it looks so ugly. rather: ~0.2.2
There was a problem hiding this comment.
I agree. Was actually looking at that very line in the PR.
On Aug 16, 2013 6:20 PM, "Sindre Sorhus" notifications@github.com wrote:
In templates/common/_package.json:
@@ -16,6 +16,7 @@
"grunt-contrib-htmlmin": "~0.1.3",
"grunt-contrib-imagemin": "~0.1.4",
"grunt-contrib-watch": "~0.4.0",
- "grunt-autoprefixer": "~0.2.20130806",
i know it's correct, but it looks so ugly. rather: ~0.2.2
—
Reply to this email directly or view it on GitHubhttps://github.com//pull/317/files#r5817661
.
|
Can you fix the merge conflict? @addyosmani ping |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is literally the first version I wrote for this, but I couldn't find any bugs. Which can only mean that my approach to testing sucks.
@addyosmani You're probably still familiar with this from your update to
generator-webapp. you mind looking over this?