Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webpack5 don‘t support? #26

Open
smileBeauty opened this issue Mar 18, 2021 · 7 comments
Open

webpack5 don‘t support? #26

smileBeauty opened this issue Mar 18, 2021 · 7 comments

Comments

@smileBeauty
Copy link

context.compiler.plugin("done", share.compilerDone);
context.compiler.plugin is not a function

@avivijiang
Copy link

+1 , I have same problem

1 similar comment
@yinshipeng
Copy link

+1 , I have same problem

@devil1989
Copy link

+1,I have the same problem

@addlistener
Copy link

@yiminghe I thinks you can easily support it by changing the webpack-dev-middleware from a dependency to a peerDependency. It works on me.

And btw, res.getHeader is used in webpack-dev-middleware. I think we should also bridge this method.

@yiminghe
Copy link
Owner

yiminghe commented Sep 6, 2022

@yiminghe I thinks you can easily support it by changing the webpack-dev-middleware from a dependency to a peerDependency. It works on me.

And btw, res.getHeader is used in webpack-dev-middleware. I think we should also bridge this method.

Can you send a pull request?

@addlistener
Copy link

addlistener commented Sep 8, 2022

https://github.com/yiminghe/koa-webpack-dev-middleware/compare/2.x...jchnxu:break_deps?expand=1

https://github.com/yiminghe/koa-webpack-dev-middleware/compare/master...jchnxu:break_deps?expand=1

Theres's only readme diff between master & 2.x. Do you think we should consider deprecating 2.x since there's no real difference?

@yiminghe
Copy link
Owner

yiminghe commented Sep 8, 2022

https://github.com/yiminghe/koa-webpack-dev-middleware/compare/2.x...jchnxu:break_deps?expand=1

https://github.com/yiminghe/koa-webpack-dev-middleware/compare/master...jchnxu:break_deps?expand=1

Theres's only readme diff between master & 2.x. Do you think we should consider deprecating 2.x since there's no real difference?

ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants