Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 7.4 Incompatibility #204

Open
pcs-matze opened this issue Dec 15, 2023 · 1 comment
Open

PHP 7.4 Incompatibility #204

pcs-matze opened this issue Dec 15, 2023 · 1 comment

Comments

@pcs-matze
Copy link

Hey! There was a new merge for issue #203

Unfortunately function getAll(Product|ProductInterface $product) is not compatible with PHP7.4 anymore cause of multiple class definition for the passing parameter.

So, composer.json does not match die requirements correctly and composer update will break code with this update in case of PHP7.4

@jissereitsma
Copy link
Collaborator

Thanks for posting. The release builder its PHP linting had an issue - not reporting PHP 7.4 properly anymore. And then my editor did the rest of the error :) This is now fixed in 3.7.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants