Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images are not displaying in product images slider on PDP page #80

Open
bharanikonda opened this issue May 20, 2021 · 10 comments
Open

Images are not displaying in product images slider on PDP page #80

bharanikonda opened this issue May 20, 2021 · 10 comments

Comments

@bharanikonda
Copy link

We have installed the module yesterday(05/19/21), except the images in the product images slider, all the other images are displaying properly in webp format on the entire website.

Can you please help us to fix the issue?

https://stage.fillmorecontainer.com/a12-05c-case12ct-1-12oz.html

@jissereitsma
Copy link
Contributor

Could you provide a bit more details IF you want to receive free support? If you want to paid support, contact me via info@yireo.com because then I'll do the troubleshooting myself. But if you are looking for free support, make sure to do everything you can to help me help you: https://github.com/yireo/Yireo_Webp2/blob/master/SUPPORT.md

@bharanikonda
Copy link
Author

Hi,

I am looking for free support, please find below details

What browser did you test this with? - I am testing in chrome browser.
What is your Magento version? What is your PHP version? - Magento 2.3.1 & PHP 7.2.34
Which version of the WebP extension did you install? - yireo/magento2-next-gen-images: 0.2.1 & yireo/magento2-webp2: 0.10.7
How did you install this module? - Through composer
Which composer command did you use, or did you copy files? - composer require yireo/magento2-webp2
What did you do to enable the module? - Yes
Have you tested this after flushing all caches? - Yes
Have you tested this after disabling all caches, especially the Full Page Cache? - Yes
Are you testing this in the Developer Mode or in the Production Mode? - Developer mode
Under Stores > Configuration > Yireo > Yireo WebP2, what settings do you see?
Value of Enabled - Yes
Value of Debug log - Yes
Value of GD support - WebP is supported by GD
Value of PHP version - 7.2.34
Value of Module version - 0.2.1
Could you supply a URL to a live demo? - https://stage.fillmorecontainer.com/a12-05c-case12ct-1-12oz.html

@jissereitsma
Copy link
Contributor

Could you fix all JavaScript errors first? The gallery is requiring JavaScript to work. With JavaScript errors, it is hard to troubleshoot anything.

@bharanikonda
Copy link
Author

Hi,

It seems the issue is with the module only. I have installed and verified it in some other applications/websites, but non of the application is displaying the slider on the product details page.

Do you have any reference website URL, on which the module is installed and the slider displaying?

Thanks.

@jissereitsma
Copy link
Contributor

Unfortunately, I don't have a public demo. But by running it in a plain Luma site it works. Simply put, the slider is based on JavaScript, the WebP trick to replace the images in that slider are based on JavaScript. But if JavaScript errors occur somewhere, the execution of all JavaScript afterwards stops. It is impossible to troubleshoot this, without cleaning up the JavaScript first.

With the module disabled, are the JavaScript errors still there? If so, fix that first.

@bharanikonda
Copy link
Author

Hi,

The slider is not displaying even after resolving the Javascript errors, please check the below URL

https://dev.fillmorecontainer.com/r09-01c-case12ct-1-12oz.html

Please verify and help us to fix the issue.

@jissereitsma
Copy link
Contributor

Hmm, it seems you are pretty passive about fixing this yourself. Please note that this module is free, which means that I've already given you a lot without asking anything in return. Now, on top of this, you are asking me to spend voluntary time on your project. Please note that this module is used by 100s of shops already without issues, so there is something specific in your own site / project / hosting environment that is preventing things from loading properly. Unfortunately, I can't drop my daily job for you and fix whatever is there to be fixed.

Are you sure you have done everything yourself to debug this already?

@jissereitsma
Copy link
Contributor

One analysis that we both (!) can easily do is confirm that the product images (JPG or WebP) are loaded in the first place by the browser. I'm not seeing any product images. So as far as I can see, there is no gallery image to convert from JPG to WebP. Could you at least post a screenshot of the gallery loading? And can you confirm that the images themselves are accessible (readable, writeable)? And is there a WebP image equivalent for those images? And if not, are you able to create those WebP image equivalents by hand?

Please note that the fact that not you, but I need to come up with simple checks like this, shows that you are not investing the same amount of energy as I am. Did you actually troubleshoot this yourself? Or do you want me to take ownership of this project? If the latter, send me an email so I can give you a custom quote.

PS: I didn't even start on this yet, but it is showing lack of care: PHP 7.2 is out of support since late 2019, Magento 2.3.1 is out of date too, etc. Problems like these are to be expected when the hosting environment has permission issues, which normally the case when a site has not been updated for so long. If performance is the issue here, I would advice upgrading PHP and Magento first, and worry about adding new extensions later.

@bharanikonda
Copy link
Author

Hi,

For the past 3 days, I have been working on this module and debugging from my side. I have verified the entire module's codebase and didn't find any logic to handle slider images. As I invested this much time, I am a little hesitant to look for alternatives earlier.

In your initial reply, you have asked me to fix the JS errors first. That's why have I had informed you after fixing JS errors.

If PHP, Magento versions are incompatible or lack of permissions from the hosting environment, I wonder how all the images on the entire website are working except the slider on PDP.

Thanks for your time on these replies, we will try other alternatives. Bye.

@btekbtek
Copy link

Looks like its working on now on your site, please share with community what was the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants