Undo manager without origin doesn't catch updates with origin

[davidbrochart]

Checklist

• Are you reporting a bug? Use github issues for bug reports and feature requests. For general questions, please use https://discuss.yjs.dev/
• Try to report your issue in the correct repository. Yjs consists of many modules. When in doubt, report it to https://github.com/yjs/yjs/issues/

Describe the bug It seems that an undo manager with no tracked origin doesn't catch updates made with an origin:

(async () => {
  const Y = await import("yjs");

  const ydoc = new Y.Doc();
  const yarray = ydoc.getArray();
  const ytext = new Y.Text("Hello");
  yarray.insert(0, [ytext]);
  const undoManager = new Y.UndoManager([], {doc: ydoc});
  undoManager.addToScope(yarray);
  undoManager.clear();
  ydoc.transact(() => {ytext.insert(5, ", world");}, 0);  // specify an origin
  console.log(undoManager.canUndo());
  // prints: false
  ytext.insert(12, "!");  // don't specify an origin
  console.log(undoManager.canUndo());
  // prints: true
})();

Expected behavior Since origins in an undo manager are only supposed to filter specific changes, I think having an undo manager with no specified origin should catch all changes, even those done with an origin set.

Environment Information

• Node.js v20.9.0
• Yjs v13.5.49

_{Huly®: YJS-797}

[dmonad]

This would be a breaking change. I also don't agree that an empty list should catch everything.

There could be an option to catch everything. However, I'd like to understand the use case first and if there are alternative solutions (there probably are)

[davidbrochart]

I also don't agree that an empty list should catch everything.

Why? The documentation says that "the changes can be optionally scoped to transaction origins". Doesn't it mean that by not specifying a transaction origin, the scope should include all origins?

My use case is simple: I want to revert a document to a previous state in time (say t0). So at t0 I create an undo manager for a shared type of this document. Somewhere, changes are made to the document with a specified origin (that I'm not aware of). Then I decide to revert the document to the state at t0. But currently the undo manager says that there is nothing to undo.

[dmonad]

The thing is that there are currently users of Yjs who specify an empty list and add origins dynamically. If I changed the behavior so that "empty" catches everything, then this would be a breaking change.

There is still the option to have a special flag to catch everything or to set the list to null. An empty list for catching everything is out of the question as it would be a breaking change.

[davidbrochart]

There is still the option to have a special flag to catch everything or to set the list to null.

Sure, that would be an option.

[davidbrochart]

Hi @dmonad, do you think this could be implemented?

[davidbrochart]

Friendly ping @dmonad 😄

[dmonad]

Hey David, sorry I can't give an estimate on when I have time to implement this feature.
I'm currently flooded with other things. This ticket takes a low priority for me because it is not relevant for the majority of users.