Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeScript: Examples and rules #309

Open
casaper opened this issue Apr 23, 2021 · 4 comments
Open

TypeScript: Examples and rules #309

casaper opened this issue Apr 23, 2021 · 4 comments
Assignees
Labels
enhancement help wanted PR welcome Please send us a pull request

Comments

@casaper
Copy link
Contributor

casaper commented Apr 23, 2021

I hardly ever write plain JS any more nowadays, so I kind of have to type these very fine examples given here for myself all the time.

So how about this:

  1. make examples in README.md in typescript as well
  2. add a @typescript-eslint/you-dont-need-lodash

I'm willing to contribute to that effort, if there is some agreement amongst the original contributors.

@cht8687
Copy link
Member

cht8687 commented Jul 10, 2021

@stevemao any thoughts on this?

@stevemao
Copy link
Member

Sounds great!

@stevemao stevemao added enhancement help wanted PR welcome Please send us a pull request and removed question labels Oct 15, 2021
@casaper
Copy link
Contributor Author

casaper commented Oct 18, 2021

@stevemao

I may have a little time to contribute with this occasionally. I suggest I'll make small PR's that do this with one or two different examples at a time.

Does that sound all right to you?

@ThickPropheT
Copy link

Until documentation is updated, any advice on getting the eslint plugin to work in a typescript project? Or is that not what this ticket is about?

I tried installing via npm using:

npm install --save-dev eslint-plugin-you-dont-need-lodash-underscore

then I added this to my .eslintrc.json:

"extends" : ["plugin:you-dont-need-lodash-underscore/compatible"]

and nothing changes. I tried restarting the IDE and that didn't help. I also tried adding this to .eslintrc.json:

"plugins": ["you-dont-need-lodash-underscore"]

also nothing.

🤷

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement help wanted PR welcome Please send us a pull request
Projects
None yet
Development

No branches or pull requests

4 participants