insecure string pickle #6840
Comments
|
Post the full output you get witht he |
|
|
That's weird, can you post the output of |
|
Uh. Mac OS X 10.11 GM now.
|
|
|
I'm not sure, but if you have upgraded to Mac OS X 10.11 you may need to reinstall/rebuild some programs with homebrew. As I said, could you try with the builtin python: Could yo try to edit /usr/local/Cellar/python/2.7.10_2/Frameworks/Python.framework/Versions/2.7/lib/python2.7/subprocess.py at line 1334 to look like this: if data != "":
try:
_eintr_retry_call(os.waitpid, self.pid, 0)
except OSError as e:
if e.errno != errno.ECHILD:
raise
# The following line is new
print(data)
child_exception = pickle.loads(data)
raise child_exceptionand run |
After modifications: |
|
Sorry, instead of Could you install python3 with homebrew and run |
|
After edit: "Sorry, instead of print(data) could you use print(repr(data)) I want to make sure I try with the correct data." Already installed, and... Cleaned that output for ya. |
|
I don't know why you get that output when using python3, it should works the same as python2. There's something wrong in the in your case it cuts the last part ( import subprocess
for exe in ['ffmpeg', 'avconv']:
print(exe)
out, _ = subprocess.Popen([exe, '-version'], stdout=subprocess.PIPE, stderr=subprocess.PIPE).communicate()
print(out) |
|
With python3 |
|
First of all: installing the Try with this script: import subprocess
for exe in ['avprobe', 'avconv', 'ffmpeg', 'ffprobe']:
print(exe)
out, _ = subprocess.Popen([exe, '-version'], stdout=subprocess.PIPE, stderr=subprocess.PIPE).communicate()
print(out)That will test the executables in same order as youtube-dl. If that works, then there is some weird interaction with the rest of youtube-dl's code. |
And, after install, looks like it's getting it, but it isn't. |
|
The second output is the expected one if you don't have libav installed (or if you run |
|
Pretty sure you had me unlink libav… relinked and it works. |
|
What I meant is that when you unlink libav you should be in the same state as when you initially got the |
|
Huh. Wondering how that got |
|
It was definitely odd. Remember to remove the |
|
Got the same issue. Installing libav, ffmpeg and rtmpdump made it work for me. Note that this was on a fresh homebrew install on a fresh El Capitan install. |
|
I had the same issue, just installing |
|
Can confirm, installing |
|
|
|
I had the same problem and I had already It didn't work in Python 2.7.10: but it worked in Python 3: I had to install |
|
Thanks for the suggestion. It may be a good idea for matplotlib but not for youtube-dl as we try to minimimize external dependencies as much as possible. Also, this issue can be closed when Python 2.7.12 is released. |
|
@kenorb thanks that worked for me. I had to add builtin since which is aliased to something else in my system: |
|
@nhoizey same thing worked for me. I had the same error, I simply and everything works now |
|
|
|
+1 for the |
|
FWIW another confirmation that updating After 🍰 🎉 ⛵ Notice the python version; after But python Three has no problem with this however |
|
interesting -- i recently switched to python3, but installed youtube-dl when i was using 2.7. i wonder if that's the issue here |
|
installing libav fixed this error for me [youtube-dl 2016.04.24, python 2.7.11, osx 10.11.4 (15E65)] |
|
|
|
ffmpeg/libav is currently an optional dependency. If you don't need to merge video/audio formats, add metadata, embed subtitles/thumbnails or any other features relying on ffmpeg/libav, there's no need to install it. This bug is caused by broken Python instead of the lack of ffmpeg/libav. Installing ffmpeg/libav is just a workaround. |
|
I had to install rtmpdump to fix mine. |
|
For those who are affected: in http://bugs.python.org/issue26083, @gpshead applied a patch on Python 2.x branch, while the patch is considered buggy. Use Python 3 before the Python bug is fixed. |
|
Python 2.7.12 is released, [1] closing. rtmpdump and libav/ffmpeg are no longer necessary for basic usages. [1] https://hg.python.org/cpython/raw-file/v2.7.12/Misc/NEWS |
|
Oddly enough, on Python 2.7.10, |
|
The default Python on Mac is still stuck at 2.7.10 (at least on macOS 10.11). |
It's not trivial to detect the reason that causes "insecure string pickle" reliably. I'm not sure it's even possible or not. If you have a concrete approach, feel free to open a new pull request.
Mandatory dependency may not be a good idea. If I remember it correctly Homebrew has recommended or optional dependencies. You may want to forward this idea to the Homebrew team. |
|
Hi Yen Chi,
Homebrew drops a binary file into the PATH. Do you know how the binary
chooses which Python runs it?
On 31 Aug 2017 4:42 PM, "Yen Chi Hsuan" <notifications@github.com> wrote:
add a more helpful error message
It's not trivial to detect the reason that causes "insecure string pickle"
reliably. I'm not sure it's even possible or not. If you have a concrete
approach, feel free to open a new pull request.
set the brew version of youtube-dl to require python3 by default?
Mandatory dependency may not be a good idea. If I remember it correctly
Homebrew has recommended or optional dependencies. You may want to forward
this idea to the Homebrew team.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#6840 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ACYh-ufhPCZXq_30yZQnoj-gM23gpUtdks5sdlXOgaJpZM4F8M0n>
.
|
Just took a look. Homebrew also uses |
|
FYI I just ran into this (#14475 is my ticket). Some Homebrew formulae accept a --with-python argument, but youtube-dl doesn't. Unfortunately they don't accept requests for changes to formulae, only pull requests, so I can't even ask them to support using Homebrew's own build of python instead of the system default, and I can't do it myself as I am not skilled in ruby or python. So for now I've just created this shell script that comes first in my $PATH: DrHyde/shellscripts@1130d7a |
Got this... Not sure about issue:
The text was updated successfully, but these errors were encountered: