Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: apply a test to group of models #94

Open
remilepriol opened this issue Sep 12, 2023 · 2 comments
Open

Feature request: apply a test to group of models #94

remilepriol opened this issue Sep 12, 2023 · 2 comments

Comments

@remilepriol
Copy link

Hello,

I would like to apply some tests to a subset of my models easily. I think the programmatic handling of yaml files by dbt osmosis could enable this, for instance by specifying some tests directly in the dbt_project.yml and having them applied when running

dbt-osmosis yaml refactor

Does this idea interest other people ? could it fit in dbt-osmosis ?

@syou6162
Copy link
Sponsor Contributor

Technically, it would not be difficult to propagate the information from the test, but it does not appear to be currently being incorporated as intended.

This is my personal opinion, but I think it is better not to incorporate it by default. It would be nice if the --add-tests option could be added.

@z3z1ma
Copy link
Owner

z3z1ma commented Sep 21, 2023

Yeah it seems a very specific situation I would want to propagate tests everywhere. Firstly the properties of columns like nullability and uniqueness may change across transformations for example during denormalization.

This would need to be opt in and I am not sure the best way other than adding a flag and leaving it to use discretion to use responsibly. Perhaps a whitelist of column.test keys which are propagatable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants