Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lexer should pass character position to parseError #16

Open
halfdan opened this issue Jan 28, 2016 · 0 comments
Open

Lexer should pass character position to parseError #16

halfdan opened this issue Jan 28, 2016 · 0 comments

Comments

@halfdan
Copy link

halfdan commented Jan 28, 2016

The Jison parser provides useful location information to its parseError function - the lexer currently does not provide any location information to parseError at all.

https://github.com/zaach/jison/blob/5e13d8563c306c66cc00b9fe22ff6da74617e792/lib/jison.js#L1037-L1043

While implementing TryGhost/GQL#4 the only solution I could find to get the location of the error was by parsing it out of the error message.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@halfdan