Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flaky TestDataClients #2556

Open
AlexanderYastrebov opened this issue Aug 31, 2023 · 8 comments · May be fixed by #2558
Open

Flaky TestDataClients #2556

AlexanderYastrebov opened this issue Aug 31, 2023 · 8 comments · May be fixed by #2558
Labels
flakytest

Comments

@AlexanderYastrebov
Copy link
Member 

--- FAIL: TestDataClients (1.02s)
    skipper_test.go:557: Waiting for proxy being ready
    skipper_test.go:557: Waiting for proxy being ready
    skipper_test.go:557: Waiting for proxy being ready
    skipper_test.go:557: Waiting for proxy being ready
    skipper_test.go:557: Waiting for proxy being ready
    skipper_test.go:557: Waiting for proxy being ready
    skipper_test.go:557: Waiting for proxy being ready
    skipper_test.go:557: Waiting for proxy being ready
    skipper_test.go:557: Waiting for proxy being ready
    skipper_test.go:557: Waiting for proxy being ready
    skipper_test.go:568: Failed to GET routes file route: Get "http://localhost:8090/routes-file": dial tcp [::1]:8090: connect: connection refused

Previous #2418
@AlexanderYastrebov AlexanderYastrebov mentioned this issue Aug 31, 2023
Merged
AlexanderYastrebov added a commit that referenced this issue Aug 31, 2023
@AlexanderYastrebov
Fix flaky TestDataClients
d5a446f 
* simplify setup boilerplate by using test t.TempDir()
* remove unrelated options and unused code
* increase startup wait interval

Fixes #2556

Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
@AlexanderYastrebov AlexanderYastrebov linked a pull request Aug 31, 2023 that will close this issue
Open
@RomanZavodskikh
Copy link
Member 

--- FAIL: TestDataClients (1.03s)
    skipper_test.go:557: Waiting for proxy being ready
    skipper_test.go:557: Waiting for proxy being ready
    skipper_test.go:557: Waiting for proxy being ready
    skipper_test.go:557: Waiting for proxy being ready
    skipper_test.go:557: Waiting for proxy being ready
    skipper_test.go:557: Waiting for proxy being ready
    skipper_test.go:557: Waiting for proxy being ready
    skipper_test.go:557: Waiting for proxy being ready
    skipper_test.go:557: Waiting for proxy being ready
    skipper_test.go:557: Waiting for proxy being ready
    skipper_test.go:568: Failed to GET routes file route: Get "http://localhost:8090/routes-file": dial tcp [::1]:8090: connect: connection refused

https://github.com/zalando/skipper/actions/runs/6299007562/job/17098937331?pr=2611#step:6:201

@RomanZavodskikh
Copy link
Member

RomanZavodskikh commented Oct 2, 2023 •
edited 

--- FAIL: TestDataClients (1.01s)
    skipper_test.go:557: Waiting for proxy being ready
    skipper_test.go:557: Waiting for proxy being ready
    skipper_test.go:557: Waiting for proxy being ready
    skipper_test.go:557: Waiting for proxy being ready
    skipper_test.go:557: Waiting for proxy being ready
    skipper_test.go:557: Waiting for proxy being ready
    skipper_test.go:557: Waiting for proxy being ready
    skipper_test.go:557: Waiting for proxy being ready
    skipper_test.go:557: Waiting for proxy being ready
    skipper_test.go:557: Waiting for proxy being ready
    skipper_test.go:568: Failed to GET routes file route: Get "http://localhost:8090/routes-file": dial tcp 127.0.0.1:8090: connect: connection refused

@RomanZavodskikh
Copy link
Member

https://github.com/zalando/skipper/actions/runs/6430876694/job/17462665927?pr=2634

--- FAIL: TestDataClients (1.02s)
    skipper_test.go:5[57](https://github.com/zalando/skipper/actions/runs/6430876694/job/17462665927?pr=2634#step:6:58): Waiting for proxy being ready
    skipper_test.go:557: Waiting for proxy being ready
    skipper_test.go:557: Waiting for proxy being ready
    skipper_test.go:557: Waiting for proxy being ready
    skipper_test.go:557: Waiting for proxy being ready
    skipper_test.go:557: Waiting for proxy being ready
    skipper_test.go:557: Waiting for proxy being ready
    skipper_test.go:557: Waiting for proxy being ready
    skipper_test.go:557: Waiting for proxy being ready
    skipper_test.go:557: Waiting for proxy being ready
    skipper_test.go:568: Failed to GET routes file route: Get "http://localhost:8090/routes-file": dial tcp [::1]:8090: connect: connection refused
2023/10/06 11:13:13 github.com/testcontainers/testcontainers-go - Connected to docker: 
  Server Version: 24.0.6
  API Version: 1.43
  Operating System: Ubuntu 22.04.3 LTS
  Total Memory: 6921 MB
  Resolved Docker Host: unix:///var/run/docker.sock
  Resolved Docker Socket Path: /var/run/docker.sock
  Test SessionID: da90c5d52f30e560cea77992[58](https://github.com/zalando/skipper/actions/runs/6430876694/job/17462665927?pr=2634#step:6:59)fec005c4ac8cb6a140d6c[62](https://github.com/zalando/skipper/actions/runs/6430876694/job/17462665927?pr=2634#step:6:63)eeaa8bc9881d50c
  Test ProcessID: 2ecd7787-8[63](https://github.com/zalando/skipper/actions/runs/6430876694/job/17462665927?pr=2634#step:6:64)5-4[77](https://github.com/zalando/skipper/actions/runs/6430876694/job/17462665927?pr=2634#step:6:78)d-ba10-b8fa94d4fb85
2023/10/06 11:13:13 Failed to get image auth for docker.io. Setting empty credentials for the image: docker.io/testcontainers/ryuk:0.5.1. Error is:credentials not found in native keychain

@AlexanderYastrebov
Copy link
Member Author 

--- FAIL: TestDataClients (1.02s)
    skipper_test.go:557: Waiting for proxy being ready
    skipper_test.go:557: Waiting for proxy being ready
    skipper_test.go:557: Waiting for proxy being ready
    skipper_test.go:557: Waiting for proxy being ready
    skipper_test.go:557: Waiting for proxy being ready
    skipper_test.go:557: Waiting for proxy being ready
    skipper_test.go:557: Waiting for proxy being ready
    skipper_test.go:557: Waiting for proxy being ready
    skipper_test.go:557: Waiting for proxy being ready
    skipper_test.go:557: Waiting for proxy being ready
    skipper_test.go:568: Failed to GET routes file route: Get "http://localhost:8090/routes-file": dial tcp [::1]:8090: connect: connection refused

@AlexanderYastrebov
Copy link
Member Author 

--- FAIL: TestDataClients (1.03s)
    skipper_test.go:557: Waiting for proxy being ready
    skipper_test.go:557: Waiting for proxy being ready
    skipper_test.go:557: Waiting for proxy being ready
    skipper_test.go:557: Waiting for proxy being ready
    skipper_test.go:557: Waiting for proxy being ready
    skipper_test.go:557: Waiting for proxy being ready
    skipper_test.go:557: Waiting for proxy being ready
    skipper_test.go:557: Waiting for proxy being ready
    skipper_test.go:557: Waiting for proxy being ready
    skipper_test.go:557: Waiting for proxy being ready
    skipper_test.go:568: Failed to GET routes file route: Get "http://localhost:8090/routes-file": dial tcp [::1]:8090: connect: connection refused
2023/10/11 23:26:51 github.com/testcontainers/testcontainers-go - Connected to docker:

https://github.com/zalando/skipper/actions/runs/6489121927/job/17622808340?pr=2672

@AlexanderYastrebov AlexanderYastrebov mentioned this issue Oct 12, 2023
Open
@RomanZavodskikh
Copy link
Member 

--- FAIL: TestDataClients (1.02s)
    skipper_test.go:557: Waiting for proxy being ready
    skipper_test.go:557: Waiting for proxy being ready
    skipper_test.go:557: Waiting for proxy being ready
    skipper_test.go:557: Waiting for proxy being ready
    skipper_test.go:557: Waiting for proxy being ready
    skipper_test.go:557: Waiting for proxy being ready
    skipper_test.go:557: Waiting for proxy being ready
    skipper_test.go:557: Waiting for proxy being ready
    skipper_test.go:557: Waiting for proxy being ready
    skipper_test.go:557: Waiting for proxy being ready
    skipper_test.go:568: Failed to GET routes file route: Get "http://localhost:8090/routes-file": dial tcp [::1]:8090: connect: connection refused
2023/10/12 11:36:57 github.com/testcontainers/testcontainers-go - Connected to docker:

https://github.com/zalando/skipper/actions/runs/6495046417/job/17639203106?pr=2673

@AlexanderYastrebov
Copy link
Member Author 

--- FAIL: TestDataClients (1.01s)
    skipper_test.go:557: Waiting for proxy being ready
    skipper_test.go:557: Waiting for proxy being ready
    skipper_test.go:557: Waiting for proxy being ready
    skipper_test.go:557: Waiting for proxy being ready
    skipper_test.go:557: Waiting for proxy being ready
    skipper_test.go:557: Waiting for proxy being ready
    skipper_test.go:557: Waiting for proxy being ready
    skipper_test.go:557: Waiting for proxy being ready
    skipper_test.go:557: Waiting for proxy being ready
    skipper_test.go:557: Waiting for proxy being ready
    skipper_test.go:568: Failed to GET routes file route: Get "http://localhost:8090/routes-file": dial tcp [::1]:8090: connect: connection refused

https://github.com/zalando/skipper/actions/runs/6527585839/job/17722620945?pr=2679

@szuecs
Copy link
Member

szuecs commented Nov 30, 2023 

 --- FAIL: TestDataClients (1.02s)
    skipper_test.go:557: Waiting for proxy being ready
    skipper_test.go:557: Waiting for proxy being ready
    skipper_test.go:557: Waiting for proxy being ready
    skipper_test.go:557: Waiting for proxy being ready
    skipper_test.go:557: Waiting for proxy being ready
    skipper_test.go:557: Waiting for proxy being ready
    skipper_test.go:557: Waiting for proxy being ready
    skipper_test.go:557: Waiting for proxy being ready
    skipper_test.go:557: Waiting for proxy being ready
    skipper_test.go:557: Waiting for proxy being ready
    skipper_test.go:568: Failed to GET routes file route: Get "http://localhost:8090/routes-file": dial tcp [::1]:8090: connect: connection refused

@AlexanderYastrebov AlexanderYastrebov mentioned this issue Feb 12, 2024
Merged
AlexanderYastrebov added a commit that referenced this issue Feb 13, 2024
@AlexanderYastrebov
cdp: disable testcontainers Ryuk
9f3afe6 
Disable reaper container for CDP builds.
This should hopefully eliminate testcontainer-related test flakes.

See https://golang.testcontainers.org/features/garbage_collector/#ryuk
and previous #2930

Updates #2668
Updates #2621
Updates #2556

Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
@AlexanderYastrebov AlexanderYastrebov mentioned this issue Feb 13, 2024
Merged
AlexanderYastrebov added a commit that referenced this issue Feb 13, 2024
@AlexanderYastrebov
cdp: disable testcontainers Ryuk (#2932)
92e14cf 
Disable reaper container for CDP builds.
This should hopefully eliminate testcontainer-related test flakes.

See https://golang.testcontainers.org/features/garbage_collector/#ryuk
and previous #2930

Updates #2668
Updates #2621
Updates #2556

Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flakytest
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix flaky TestDataClients zalando/skipper
3 participants
@szuecs @AlexanderYastrebov @RomanZavodskikh