Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use of alias_method_chain has been depreciated in Rails 5 #270

Closed
jorroll opened this issue Apr 14, 2016 · 1 comment · Fixed by #271
Closed

Use of alias_method_chain has been depreciated in Rails 5 #270

jorroll opened this issue Apr 14, 2016 · 1 comment · Fixed by #271

Comments

@jorroll
Copy link

jorroll commented Apr 14, 2016

This is my first time using Github / commenting on a project, so forgive me if I've made a mistake, but while upgrading my Rails 4.2 app to Rails 5, I've encountered a depreciation warning related to activerecord-import's use of alias_method_chain found in lib > activerecord-import.rb.

As detailed here in Riding on Rails, and here in this Rails pull request 19434, alias_method_chain has been depreciated in favor of Module.prepend. I've looked into offering up a fix using Module.prepend, but I'm afraid I'm just not knowledgeable enough in Ruby.

@zdennis
Copy link
Owner

zdennis commented Jun 12, 2016

Thanks for reporting this @thefliik. I've known about this for a while, but I've ignored it since alias_method_chain is so much more readable than trying to follow Module#prepend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants