Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SameCodes assumes the cache is always correct #9

Open
Resisty opened this issue Oct 14, 2016 · 1 comment
Open

SameCodes assumes the cache is always correct #9

Resisty opened this issue Oct 14, 2016 · 1 comment
Assignees
Labels
Milestone

Comments

@Resisty
Copy link

Resisty commented Oct 14, 2016

In geo.py, SameCodes._cached_same_codes() returns True regardless of the contents of the cache file. After a failed run, the cache file existed on my file system but was empty. Subsequent attempts all failed because no SAME codes were available.

In addition to checking if the file exists, please ensure that the cache also has useful information and if not, reload().

Thanks!

@zebpalmer zebpalmer self-assigned this Oct 14, 2016
@zebpalmer
Copy link
Owner

Thanks for the report. This is ancient code, surprised it still works at all. I am planning on giving it some TLC early next month. Revamping the cache logic is on the list.

@zebpalmer zebpalmer added the bug label Oct 14, 2016
@zebpalmer zebpalmer added this to the v6 milestone Oct 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants