Fix for http://yellowgrass.org/issue/persistence.js/14 (Memory Leak in

trackedObjects)
coresmart · Aug 23, 2010 · bfd2893 · bfd2893
1 parent 058dd6e
commit bfd2893
Showing 1 changed file with 8 additions and 2 deletions.
diff --git a/persistence.store.sql.js b/persistence.store.sql.js
@@ -655,10 +655,16 @@ persistence.store.sql.config = function(persistence, dialect) {
     var whereSql = "WHERE "
     + [ this._filter.sql("", args) ].concat(additionalWhereSqls).join(' AND ');
 
-    var sql = "DELETE FROM `" + entityName + "` " + joinSql + ' ' + whereSql;
+    var selectSql = "SELECT id FROM `" + entityName + "` " + joinSql + ' ' + whereSql;
+    var deleteSql = "DELETE FROM `" + entityName + "` " + joinSql + ' ' + whereSql;
 
     session.flush(tx, function () {
-        tx.executeSql(sql, args, callback);
+        tx.executeSql(selectSql, args, function(results) {
+            for(var i = 0; i < results.length; i++) {
+              delete session.trackedObjects[results[i].id];
+            }
+            tx.executeSql(deleteSql, args, callback);
+          });
       });
   };