Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Signing the Windows installer #96

Open
TheRustifyer opened this issue Oct 26, 2023 · 0 comments · Fixed by 0nSystem/Zork#2
Open

Signing the Windows installer #96

TheRustifyer opened this issue Oct 26, 2023 · 0 comments · Fixed by 0nSystem/Zork#2
Assignees
@0nSystem
Labels
feature Something new in the application or library improvement

Comments

@TheRustifyer
Copy link
Member

Feature Request

Currently, when the Windows installer is created via Inno, the package isn't signed or authored by our organization.
This leads to Windows typically block it's installation with the Smart Screen, so the user requires to do additional steps to start the installation.

With this in mind, we need a way to correctly set up our Windows installer.
@TheRustifyer TheRustifyer added improvement feature Something new in the application or library labels Oct 26, 2023
@0nSystem 0nSystem linked a pull request Dec 2, 2023 that will close this issue
v0.8.8 0nSystem/Zork#2
Merged
0nSystem added a commit to 0nSystem/Zork that referenced this issue Dec 2, 2023
@0nSystem
Merge pull request #2 from 0nSystem/feature/zerodaycodeGH-96-signing-…
d6b1b3c 
…the-windows-installer

v0.8.8
Pylyv added a commit that referenced this issue Dec 10, 2023
@Pylyv
Revert "Merge pull request #2 from 0nSystem/feature/GH-96-signing-the…
f8c8595 
…-windows-installer"

This reverts commit d6b1b3c, reversing
changes made to f907713.
@0nSystem 0nSystem reopened this Dec 16, 2023
@0nSystem 0nSystem mentioned this issue Apr 2, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@0nSystem 0nSystem

Labels
feature Something new in the application or library improvement
Projects
Zork
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feature/GH-96-signing-the-windows-installer-v2 0nSystem/Zork
v0.8.8 0nSystem/Zork
2 participants
@0nSystem @TheRustifyer