How to overwrite a file with less content

[sphaero]

It seems it updates the file in place leaving the old content in the tail.

zfile_output calls fopen (self->fullname, "r+b"); which according to docs:

r+ or rb+ or r+b: Open file for update (reading and writing).

To write the new file without a tail of old data we'd need:

w+ or wb+ or w+b
Truncate to zero length or create file for update.

However the old behaviour is probably also needed? Perhaps we need to add another method like zfile_output_truncate ?

[sphaero]

A fix could be something like this:

                    ssize_t oldSize = zfile_size(zfile_filename(file, NULL));
                    int rc = zfile_output(file);
                    if (rc == 0) {
                        zchunk_t* data = zchunk_frommem(text, strlen(text), nullptr, nullptr);
                        int rc = zfile_write(file, data, 0);
                        if (oldSize > strlen(text) )
                        {
#ifdef __WINDOWS__          // truncate the file
                            if ( _chsize_s(fileno(zfile_handle(current_editor->file)), (__int64)strlen(text)) != 0 )
                            {
                                zsys_error("Some error trying to truncate the file");
                            }
#else
                            ftruncate(fileno(zfile_handle(current_editor->file)), strlen(text));
#endif
                        }
                        zfile_close(current_editor->file);

[stale]

This issue has been automatically marked as stale because it has not had recent activity for 90 days. It will be closed if no further activity occurs within 21 days. Thank you for your contributions.

[sphaero]

Don't closeas this needs fixin or proper instructions