Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gltfpack removes existing KHR_textures_basisu extension #537

Closed
prollin opened this issue Feb 9, 2023 · 4 comments · Fixed by #692
Closed

gltfpack removes existing KHR_textures_basisu extension #537

prollin opened this issue Feb 9, 2023 · 4 comments · Fixed by #692

Comments

@prollin
Copy link

prollin commented Feb 9, 2023

Running gltfpack on a file already using the KHR_textures_basisu extension removes all traces of the extension in the output file

@zeux
Copy link
Owner

zeux commented Feb 13, 2023

This is not a bug and rather a current limitation - you can pass -tc to recompress source textures if they are present. If KHR_texture_basisu is a required extension, gltfpack currently will refuse to process the file, because it assumes the role of a tool that converts a "vanilla" glTF file (that doesn't use various compression extensions) to an optimized one (that might).

@prollin
Copy link
Author

prollin commented Feb 13, 2023

For context, our use case was to use gltf-transform (or custom tool) for compression since it gave us a bit more flexibility there and gltfpack for geometry.

@zeux
Copy link
Owner

zeux commented Mar 1, 2023

Got it, thanks. Out of curiosity, what prevents you from using gltfpack to compress the textures as well?

@prollin
Copy link
Author

prollin commented Mar 9, 2023

gltf-transform offers more granularity and more options for texture processing; we want to be able to resize certain class of textures and also have a bit more control over compression parameters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants