Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gltfpack: Simplification take in account the vertex color #652

Closed
Makio64 opened this issue Jan 28, 2024 · 2 comments · Fixed by #688
Closed

gltfpack: Simplification take in account the vertex color #652

Makio64 opened this issue Jan 28, 2024 · 2 comments · Fixed by #688

Comments

@Makio64
Copy link

Makio64 commented Jan 28, 2024

Would be nice if the algorithm take in account the vertex color to preserve the shape when of differents vertex color zone, here an example :
image
image

The mouth area is particulary destroy in this example while there is so many other triangle to collapse,

The model which have no texture is good to test, all copyright to his author from sketchfab - free download :
https://sketchfab.com/3d-models/bananya-birbo-900ce1ec328e486296cfee70b9b13a45

@zeux zeux added the gltfpack label Jan 28, 2024
@zeux zeux changed the title Simplification take in account the vertex color gltfpack: Simplification take in account the vertex color Jan 28, 2024
@zeux
Copy link
Owner

zeux commented Feb 1, 2024

Yeah I planned to add this eventually, need to figure out how to activate this from command line and configure best. The simplifier now supports attribute weighted simplification, it just hasn't made its way to gltfpack. Quickly added this just to check what the results on this model would be and they seem good, this is 0.25 simplification ratio (1/4x triangles), current master vs attribute aware simplification.

image

image

Will work on this in the near future.

@Makio64
Copy link
Author

Makio64 commented Feb 1, 2024

Attribute aware looks so much better and I think this mesh is cool to test it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants