New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missed a colon in InfoGAN code #8

Open

back2yes opened this issue Mar 3, 2018 · 1 comment

back2yes commented Mar 3, 2018 •

edited

Great job. By the way, I found this line of code doubtful:

pytorch-generative-model-collections/infoGAN.py

Line 78 in 5207b2f

a = F.sigmoid(x[:, self.output_dim])

Maybe this line should be changed into:
a = F.sigmoid(x[:, : self.output_dim])

jmmcd commented May 23, 2018

Agreed - just spotted your issue after making this fix in a pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment