Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Deleting a line (via CMD + BACKSPACE) when the range selection is at a decorator node does not work #6047

Open
nimeshnayaju opened this issue May 7, 2024 · 0 comments
Open

Bug: Deleting a line (via CMD + BACKSPACE) when the range selection is at a decorator node does not work #6047

nimeshnayaju opened this issue May 7, 2024 · 0 comments
Labels
contribution-week Issues that are good to be picked up for the contribution week good first issue Good for newcomers mac-bug

Comments

@nimeshnayaju
Copy link

Lexical version: 0.14.5

Steps To Reproduce

  1. Add a decorator node (e.g. Poll/Image)
  2. Set the selection right at the end of the node. (screencast attached)
  3. Attempt to delete the line (via Cmd + Backspace on Mac)

I believe this is an unintended side effect of this PR. The PR checks if the anchor node is of type text before extending the selection but notice in the screencast, the anchor node is of type element, so the selection isn't expanded before the text in selection is removed.

Kapture.2024-05-07.at.10.28.35.mp4
@StyleT StyleT added good first issue Good for newcomers mac-bug contribution-week Issues that are good to be picked up for the contribution week labels May 7, 2024
@DraXu3 DraXu3 mentioned this issue May 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
contribution-week Issues that are good to be picked up for the contribution week good first issue Good for newcomers mac-bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@StyleT @nimeshnayaju