Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove automatic camel-casing of CSS custom properties #73

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

necolas
Copy link
Contributor

@necolas necolas commented Apr 3, 2024

Thinking we should first update internal theme configs for native so that they don't rely on this transform. Then we can merge the PR and safely sync.

Fix #50

Copy link

github-actions bot commented Apr 3, 2024

compressed-size: runtime library

Size change: -0.02 kB
Total size: 18.84 kB

Filename: gzip (minify) kB size kB change % change
./packages/react-strict-dom/dist/native/index.js 14.91 (46.59) -0.02 (-0.08) -0.2% (-0.2%) 🟢
View unchanged
Filename: gzip (minify) kB size kB change % change
./packages/react-strict-dom/dist/dom/index.js 2.99 (8.99) 0.00 (0.00) 0.0% (0.0%)
./packages/react-strict-dom/dist/dom/runtime.js 0.95 (2.33) 0.00 (0.00) 0.0% (0.0%)

Copy link
Contributor

@vincentriemer vincentriemer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@nmn nmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well!

@Victor1890
Copy link

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove automatic camel-casing of CSS custom property names
5 participants