Flow type support for data-* props #71
Labels
Comments
|
While we wait for the Flow team to prioritise and implement the This will avoid the need for patch files when we try to maintain a list of props used internally. We can also shadow this file with a |
necolas
pushed a commit
that referenced
this issue
Apr 4, 2024
Allow arbitrary data-* props at runtime. On web, the check is only performed during development. To workaround Flow's lack of support for typing arbitary data-* props, a separate type is created just for data-* props which can be used to maintain an app's list of supported data-* props. Ref #71 Close #75
necolas
pushed a commit
that referenced
this issue
Apr 4, 2024
Allow arbitrary data-* props at runtime. On web, the check is only performed during development. To workaround Flow's lack of support for typing arbitary data-* props, a separate type is created just for data-* props which can be used to maintain an app's list of supported data-* props. Ref #71 Close #75
necolas
added a commit
that referenced
this issue
Apr 5, 2024
Allow arbitrary data-* props at runtime. On web, the check is only performed during development. To workaround Flow's lack of support for typing arbitary data-* props, a separate type is created just for data-* props which can be used to maintain an app's list of supported data-* props. Ref #71 Close #75
necolas
added a commit
that referenced
this issue
Apr 5, 2024
Allow arbitrary data-* props at runtime. On web, the check is only performed during development. To workaround Flow's lack of support for typing arbitary data-* props, a separate type is created just for data-* props which can be used to maintain an app's list of supported data-* props. Ref #71 Close #75
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the feature request
Flow doesn't have support for typing arbitrary
data-*props. This requires RSD to add Meta-specificdata-*props on an as-needed basis, and each time it is considered a "blocker" by the team migrating components to RSD. This creates incentives to either 1) patch internally generated RSD syncs with new Flow types (complicates syncs, can cause regressions), or 2) add Meta-specific props to the OSS project code (doesn't scale to other users).cc @jbrown215 who had ideas on how to support this from the Flow side
The text was updated successfully, but these errors were encountered: