[React 19] react-compiler warns when mutating globals inside useCallback #29132
Comments
josephsavona
added a commit
that referenced
this issue
May 17, 2024
…moize/FinishMemoize By default, React Compiler will skip compilation if it cannot preserve existing memoization. Ie, if the code has an existing `useMemo()` or `useCallback()` and the compiler cannot determine that it is safe to keep that memoization — or do even better — then we'll leave the code alone. The actual compilation doesn't use any hints from existing memo calls, this is purely to check and avoid regressing any specific memoization that developers may have already applied. However, we were accidentally reporting some false-positive _validation_ errors due to the StartMemoize and FinishMemoize instructions that we emit to track where the memoization was in the source code. This is now fixed. Fixes #29131 Fixes #29132 [ghstack-poisoned]
josephsavona
added a commit
that referenced
this issue
May 17, 2024
…moize/FinishMemoize By default, React Compiler will skip compilation if it cannot preserve existing memoization. Ie, if the code has an existing `useMemo()` or `useCallback()` and the compiler cannot determine that it is safe to keep that memoization — or do even better — then we'll leave the code alone. The actual compilation doesn't use any hints from existing memo calls, this is purely to check and avoid regressing any specific memoization that developers may have already applied. However, we were accidentally reporting some false-positive _validation_ errors due to the StartMemoize and FinishMemoize instructions that we emit to track where the memoization was in the source code. This is now fixed. Fixes #29131 Fixes #29132 ghstack-source-id: 9f6b8dbc5074ccc96e6073cf11c4920b5375faf6 Pull Request resolved: #29154
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Summary
https://playground.react.dev/#N4Igzg9grgTgxgUxALhAHQHYIB4AcIwAuABACYIBmAhlADYkVQZyECWEGxAsgJ4CCuXAAoAlMWCZMxYnA5gSMBGFYAvBMQC8xKGAQBhKrVoAjKnADWQqdOKjNAPnHWbxAO6sMpCK4B0FCBCaxADkpjDBzsQAvgA0kQDaALrWItbWioSwnAA8pKwAbvYAEghGgQDqBLSk2QD0eYUA3JhRmCBRQA
The text was updated successfully, but these errors were encountered: