-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
html comments not removed #360
Comments
html: {
removeComments: true,
}, is invalid option syntax. You should do: (await import("@playform/compress")).default({
HTML: {
"html-minifier-terser": {
removeComments: true
}
}
}), |
Hi @NikolaRHristov, thanks for your help. I'm not sure what is wrong. I'm also using icon, tailwind and sitemap integrations. This is my astro.config.mjs
any idea? thanks! |
We've also added new Compress/Source/Variable/HTML/html-minifier-terser.ts Lines 11 to 18 in 92c51ca
ignoreCustomComments: [
/^\s*#/,
/.*$.*/,
/^\s*\[/,
/^\s*\]/,
/^\s*!/,
/^\s*\//,
], which might interfere with this. Can you also set import {defineConfig} from "astro/config";
import sitemap from "@astrojs/sitemap";
import tailwind from "@astrojs/tailwind";
import icon from "astro-icon";
import playformCompress from "@playform/compress";
export default defineConfig({
site: "https://www.MYWEBSITE.org"
integrations: [
sitemap(),
tailwind(),
icon(),
(await import("@playform/compress")).default({
Image: false,
HTML: {
"html-minifier-terser": {
removeComments: true,
ignoreCustomComments: [],
},
},
}),
],
image: {
remotePatterns: [
{
hostname: "192.168.6.11",
port: "8055",
},
],
},
prefetch: {
prefetchAll: true,
},
}); |
This seems to have solved the issue! 👍 |
Can I just check, sorry to bother. What were the comments that were not getting removed ? Can you paste an example ? |
I'm not sure but it looks like all of them were not getting removed. Those are plain simple <!-- some text --> and <!-- ---- SECTION x ---- --> I guess there must be something messy in the code that interferes with that, possibly some non properly closed comment field? |
FWIW, I was having the same issue and adding this section HTML: {
"html-minifier-terser": {
removeComments: true,
ignoreCustomComments: [],
},
}, also solved it for me. |
Hello!
I'm not sure if this the expected behavior but comments in html are not removed in my build.
I even tried
in the astro config file but comments are still there.
Any clue why this happens?
thanks!
The text was updated successfully, but these errors were encountered: