Can't install master version of jruby-openssl #195
Comments
|
have you tried running |
|
I could not reproduce, but the debug output does show three things:
Perhaps you can check the log and see if it provides more information? Alternatively, you could reassemble this command line and see what happens on your system. |
Oh, I should've mentioned this for the complete story. I did try |
|
It seems a problem with the built If I do |
The log no longer exists after |
|
I tried to open the built jar and it's indeed empty. There's no compiled stuff in there. |
|
Ok, I figured it out! 🎉 🎉 After noticing that the jar file was empty, I thought the problem would be around compilation because by the log it seemed that nothing was getting compiled ( So I reviewed the compiler's plugin configuration and noticed that the sources location seemed wrong, so I changed it like this: diff --git a/pom.xml b/pom.xml
index 552790c..5b8e57c 100644
--- a/pom.xml
+++ b/pom.xml
@@ -271,7 +271,7 @@ DO NOT MODIFIY - GENERATED CODE
</goals>
<configuration>
<includes>
- <include>org/jruby/gen/**/*.java</include>
+ <include>org/jruby/**/*.java</include>
</includes>
<optimize>true</optimize>
<compilerArgs>And now, the sources are correctly picked up and compiled (even if with a bunch of warnings)! I was able to build, install, and use the generated gem, and confirm that the warnings meant to be fixed by #194 are indeed fixed for me 🎉. Now, my question is. The diff --git a/Mavenfile b/Mavenfile
index 591ea52..3b6a169 100644
--- a/Mavenfile
+++ b/Mavenfile
@@ -64,7 +64,7 @@ plugin( :compiler, '3.1',
execute_goal :compile,
:id => 'compile-populators', :phase => 'process-classes',
- :includes => [ 'org/jruby/gen/**/*.java' ],
+ :includes => [ 'org/jruby/**/*.java' ],
:optimize => true,
:compilerArgs => [ '', '-XDignore.symbol.file=true' ]
endHow do I regenerate |
|
there's a two phases of javac compilation as populators are generated during the first phase. setup is similar to JRuby's https://github.com/jruby/jruby/blob/master/.mvn/extensions.xml I am going to push a |
|
Nice, thanks, teaching I had just managed to automate regeneration of the diff --git a/pom.xml b/pom.xml
index 552790c..ca375c1 100644
--- a/pom.xml
+++ b/pom.xml
@@ -60,18 +60,18 @@ DO NOT MODIFIY - GENERATED CODE
</snapshotRepository>
</distributionManagement>
<properties>
+ <runit.dir>src/test/ruby/**/test_*.rb</runit.dir>
+ <polyglot.dump.readonly>true</polyglot.dump.readonly>
<bc.versions>1.62</bc.versions>
- <invoker.skip>${maven.test.skip}</invoker.skip>
<invoker.test>${bc.versions}</invoker.test>
- <jruby.plugins.version>1.1.8</jruby.plugins.version>
- <jruby.switches>-W0</jruby.switches>
- <jruby.version>9.1.17.0</jruby.version>
- <jruby.versions>9.1.17.0</jruby.versions>
<mavengem-wagon.version>1.0.3</mavengem-wagon.version>
- <mavengem.wagon.version>1.0.3</mavengem.wagon.version>
<polyglot.dump.pom>pom.xml</polyglot.dump.pom>
- <polyglot.dump.readonly>true</polyglot.dump.readonly>
- <runit.dir>src/test/ruby/**/test_*.rb</runit.dir>
+ <mavengem.wagon.version>1.0.3</mavengem.wagon.version>
+ <jruby.version>9.2.9.0</jruby.version>
+ <jruby.plugins.version>1.1.8</jruby.plugins.version>
+ <invoker.skip>${maven.test.skip}</invoker.skip>
+ <jruby.switches>-W0</jruby.switches>
+ <jruby.versions>9.2.9.0</jruby.versions>
</properties>
<dependencies>
<dependency>
@@ -433,8 +433,8 @@ DO NOT MODIFIY - GENERATED CODE
</plugins>
</build>
<properties>
- <bc.versions>1.56,1.57,1.58,1.59,1.60,1.61,1.62,1.63,1.64</bc.versions>
<jruby.modes>1.9,2.0</jruby.modes>
+ <bc.versions>1.56,1.57,1.58,1.59,1.60,1.61,1.62,1.63,1.64</bc.versions>
<jruby.versions>1.7.20</jruby.versions>
</properties>
</profile>
@@ -471,8 +471,8 @@ DO NOT MODIFIY - GENERATED CODE
</plugins>
</build>
<properties>
- <bc.versions>1.56,1.57,1.58,1.59,1.60,1.61,1.62,1.63,1.64</bc.versions>
<jruby.modes>1.9,2.0</jruby.modes>
+ <bc.versions>1.56,1.57,1.58,1.59,1.60,1.61,1.62,1.63,1.64</bc.versions>
<jruby.versions>1.7.22</jruby.versions>
</properties>
</profile>
@@ -509,8 +509,8 @@ DO NOT MODIFIY - GENERATED CODE
</plugins>
</build>
<properties>
- <bc.versions>1.56,1.57,1.58,1.59,1.60,1.61,1.62,1.63,1.64</bc.versions>
<jruby.modes>1.9,2.0</jruby.modes>
+ <bc.versions>1.56,1.57,1.58,1.59,1.60,1.61,1.62,1.63,1.64</bc.versions>
<jruby.versions>1.7.23</jruby.versions>
</properties>
</profile>
@@ -547,8 +547,8 @@ DO NOT MODIFIY - GENERATED CODE
</plugins>
</build>
<properties>
- <bc.versions>1.56,1.57,1.58,1.59,1.60,1.61,1.62,1.63,1.64</bc.versions>
<jruby.modes>1.9,2.0</jruby.modes>
+ <bc.versions>1.56,1.57,1.58,1.59,1.60,1.61,1.62,1.63,1.64</bc.versions>
<jruby.versions>1.7.24</jruby.versions>
</properties>
</profile>
@@ -585,8 +585,8 @@ DO NOT MODIFIY - GENERATED CODE
</plugins>
</build>
<properties>
- <bc.versions>1.56,1.57,1.58,1.59,1.60,1.61,1.62,1.63,1.64</bc.versions>
<jruby.modes>1.9,2.0</jruby.modes>
+ <bc.versions>1.56,1.57,1.58,1.59,1.60,1.61,1.62,1.63,1.64</bc.versions>
<jruby.versions>1.7.25</jruby.versions>
</properties>
</profile>
@@ -623,8 +623,8 @@ DO NOT MODIFIY - GENERATED CODE
</plugins>
</build>
<properties>
- <bc.versions>1.56,1.57,1.58,1.59,1.60,1.61,1.62,1.63,1.64</bc.versions>
<jruby.modes>1.9,2.0</jruby.modes>
+ <bc.versions>1.56,1.57,1.58,1.59,1.60,1.61,1.62,1.63,1.64</bc.versions>
<jruby.versions>1.7.26</jruby.versions>
</properties>
</profile>
@@ -661,8 +661,8 @@ DO NOT MODIFIY - GENERATED CODE
</plugins>
</build>
<properties>
- <bc.versions>1.56,1.57,1.58,1.59,1.60,1.61,1.62,1.63,1.64</bc.versions>
<jruby.modes>1.9,2.0</jruby.modes>
+ <bc.versions>1.56,1.57,1.58,1.59,1.60,1.61,1.62,1.63,1.64</bc.versions>
<jruby.versions>1.7.27</jruby.versions>
</properties>
</profile>
@@ -700,8 +700,8 @@ DO NOT MODIFIY - GENERATED CODE
</build>
<properties>
<bc.versions>1.56,1.57,1.58,1.59,1.60,1.61,1.62,1.63,1.64</bc.versions>
- <jruby.version>9.0.1.0</jruby.version>
<jruby.versions>9.0.1.0</jruby.versions>
+ <jruby.version>9.0.1.0</jruby.version>
</properties>
</profile>
<profile>
@@ -738,8 +738,8 @@ DO NOT MODIFIY - GENERATED CODE
</build>
<properties>
<bc.versions>1.56,1.57,1.58,1.59,1.60,1.61,1.62,1.63,1.64</bc.versions>
- <jruby.version>9.0.5.0</jruby.version>
<jruby.versions>9.0.5.0</jruby.versions>
+ <jruby.version>9.0.5.0</jruby.version>
</properties>
</profile>
<profile>
@@ -776,8 +776,8 @@ DO NOT MODIFIY - GENERATED CODE
</build>
<properties>
<bc.versions>1.56,1.57,1.58,1.59,1.60,1.61,1.62,1.63,1.64</bc.versions>
- <jruby.version>9.1.2.0</jruby.version>
<jruby.versions>9.1.2.0</jruby.versions>
+ <jruby.version>9.1.2.0</jruby.version>
</properties>
</profile>
<profile>
@@ -814,8 +814,8 @@ DO NOT MODIFIY - GENERATED CODE
</build>
<properties>
<bc.versions>1.56,1.57,1.58,1.59,1.60,1.61,1.62,1.63,1.64</bc.versions>
- <jruby.version>9.1.8.0</jruby.version>
<jruby.versions>9.1.8.0</jruby.versions>
+ <jruby.version>9.1.8.0</jruby.version>
</properties>
</profile>
<profile>
@@ -852,8 +852,8 @@ DO NOT MODIFIY - GENERATED CODE
</build>
<properties>
<bc.versions>1.56,1.57,1.58,1.59,1.60,1.61,1.62,1.63,1.64</bc.versions>
- <jruby.version>9.1.12.0</jruby.version>
<jruby.versions>9.1.12.0</jruby.versions>
+ <jruby.version>9.1.12.0</jruby.version>
</properties>
</profile>
<profile>
@@ -890,8 +890,8 @@ DO NOT MODIFIY - GENERATED CODE
</build>
<properties>
<bc.versions>1.56,1.57,1.58,1.59,1.60,1.61,1.62,1.63,1.64</bc.versions>
- <jruby.version>9.1.16.0</jruby.version>
<jruby.versions>9.1.16.0</jruby.versions>
+ <jruby.version>9.1.16.0</jruby.version>
</properties>
</profile>
<profile>
@@ -928,8 +928,8 @@ DO NOT MODIFIY - GENERATED CODE
</build>
<properties>
<bc.versions>1.56,1.57,1.58,1.59,1.60,1.61,1.62,1.63,1.64</bc.versions>
- <jruby.version>9.1.17.0</jruby.version>
<jruby.versions>9.1.17.0</jruby.versions>
+ <jruby.version>9.1.17.0</jruby.version>
</properties>
</profile>
<profile>
@@ -966,8 +966,8 @@ DO NOT MODIFIY - GENERATED CODE
</build>
<properties>
<bc.versions>1.56,1.57,1.58,1.59,1.60,1.61,1.62,1.63,1.64</bc.versions>
- <jruby.version>9.2.0.0</jruby.version>
<jruby.versions>9.2.0.0</jruby.versions>
+ <jruby.version>9.2.0.0</jruby.version>
</properties>
</profile>
<profile>
@@ -1004,8 +1004,8 @@ DO NOT MODIFIY - GENERATED CODE
</build>
<properties>
<bc.versions>1.56,1.57,1.58,1.59,1.60,1.61,1.62,1.63,1.64</bc.versions>
- <jruby.version>9.2.5.0</jruby.version>
<jruby.versions>9.2.5.0</jruby.versions>
+ <jruby.version>9.2.5.0</jruby.version>
</properties>
</profile>
<profile>
@@ -1042,8 +1042,8 @@ DO NOT MODIFIY - GENERATED CODE
</build>
<properties>
<bc.versions>1.56,1.57,1.58,1.59,1.60,1.61,1.62,1.63,1.64</bc.versions>
- <jruby.version>9.2.6.0</jruby.version>
<jruby.versions>9.2.6.0</jruby.versions>
+ <jruby.version>9.2.6.0</jruby.version>
</properties>
</profile>
<profile>
@@ -1080,8 +1080,8 @@ DO NOT MODIFIY - GENERATED CODE
</build>
<properties>
<bc.versions>1.56,1.57,1.58,1.59,1.60,1.61,1.62,1.63,1.64</bc.versions>
- <jruby.version>9.2.7.0</jruby.version>
<jruby.versions>9.2.7.0</jruby.versions>
+ <jruby.version>9.2.7.0</jruby.version>
</properties>
</profile>
<profile>
@@ -1118,8 +1118,8 @@ DO NOT MODIFIY - GENERATED CODE
</build>
<properties>
<bc.versions>1.56,1.57,1.58,1.59,1.60,1.61,1.62,1.63,1.64</bc.versions>
- <jruby.version>9.2.8.0</jruby.version>
<jruby.versions>9.2.8.0</jruby.versions>
+ <jruby.version>9.2.8.0</jruby.version>
</properties>
</profile>
<profile>
@@ -1156,8 +1156,8 @@ DO NOT MODIFIY - GENERATED CODE
</build>
<properties>
<bc.versions>1.56,1.57,1.58,1.59,1.60,1.61,1.62,1.63,1.64</bc.versions>
- <jruby.version>9.2.9.0</jruby.version>
<jruby.versions>9.2.9.0</jruby.versions>
+ <jruby.version>9.2.9.0</jruby.version>
</properties>
</profile>
<profile>Anyways, I'll wait for you to push this manifest, since definitely sounds like the way to go :) |
|
Thanks for helping out. So, some logs seem slightly different, but the error seems like the same thing: `JAVA_OPTS=--illegal-access mvn package -Dmaven.test.skip=true` log hereThe
|
|
Also, note that running the command that TravisCI is running under java 11 fails exactly in the same way on my machine. The fact that the TravisCI job is green seems like process status misreport, but the command is failing. |
|
Able to reproduce on Java 11. Tried looking into updating the build but I am not really up for getting myself into a rewrite (not even sure what would be best, just messing with plain pom.xml or moving to build.gradle). This seems like yet another compatibility issue, the maven compiler plugin should be fine to work with Java 11 ... not sure why it ends up not picking up the files and producing an empty .jar. Have been using Java 8 to build the project pretty much exclusively, recall doing experiments with generating a |
|
oh right, I see - thought the compiler plugin was upgraded but wasn't due issues with the 2 phases. |
|
Thanks for your research! :) |
|
@kares Do you know where are The fix for TravisCI not reporting the right status seems simple enough to fix, but I can't find where to contribute it! |
|
Still wondering about this, since I had never seen such a situation. |
|
Hey David, sorry your guess is as good as mine, was part of polyglot at some point. |
|
Thanks, that link is helpful and sheds a bit more light. It apparently lived there indeed and then it was "moved to its own repo" back in takari/polyglot-maven@1ef30a1. But it's unclear what this new repo lives. My current guess is that the @takari organization has continued development on this new repo, but forgot to make it public when the move was made. I guess we could also ask @mosabua (only public member of the @takari organization) and @jvanzyl (author of the commit that I just mentioned). |
|
There is no ruby-maven repo in the takari org. I help with releases of polyglot-maven which includes the jruby dialect. I dont know about ruby-maven myself. @mkristian did look at upgrading polyglot for Java 11 a bit. I am not sure where ruby-maven lives .. maybe @headius knows a bit more as well.. |
|
Thanks for responding @mosabua anyways. Hopefully we'll find out the answers :) |
|
@deivid-rodriguez I resurrected the ruby-maven repo on https://github.com/jruby/ruby-maven |
|
Thanks! I'll contribute a patch :) |
|
Awesome @mkristian .. we should work towards getting polyglot-maven to Java 11 .. |
|
Ok, so funny enough, the fix I want to contribute belongs in a library called @mkristian I assume you intend to publish that too since there's now an empty https://github.com/jruby/ruby-maven-libs repo. Right? |
|
@deivid-rodriguez right - I hoped this is not so pressing. this just the maven distribution repack into a gem. what kind of fix you want to make there ? I will work on this then. |
|
No, not pressing at all! The problem is that current The problem lies in the |
|
the problem is that I did find some old code on backup but not the current setup where the ruby-maven and ruby-maven-libs are split into two. |
|
I guess you can |
|
@deivid-rodriguez have look if this helps: https://github.com/jruby/ruby-maven-libs since I follow the version of the underlying maven it would need a newer maven version which is probably a good idea as well :) |
|
Thanks a lot! I'll work on my fix! |
|
I'll close this now, since I can now install the master version of |
|
I'm reopening this because I'm not sure why I closed it. I still need the following local patch to be able to diff --git a/Mavenfile b/Mavenfile
index 591ea52..3b6a169 100644
--- a/Mavenfile
+++ b/Mavenfile
@@ -64,7 +64,7 @@ plugin( :compiler, '3.1',
execute_goal :compile,
:id => 'compile-populators', :phase => 'process-classes',
- :includes => [ 'org/jruby/gen/**/*.java' ],
+ :includes => [ 'org/jruby/**/*.java' ],
:optimize => true,
:compilerArgs => [ '', '-XDignore.symbol.file=true' ]
end
diff --git a/Rakefile b/Rakefile
index 67c47b2..52597de 100644
--- a/Rakefile
+++ b/Rakefile
@@ -1,5 +1,7 @@
#-*- mode: ruby -*-
+require "bundler/gem_tasks"
+
begin
require 'ruby-maven'
rescue LoadError |
|
Hello 👋 👋! I still see these warnings when starting up jruby. It'd be really nice if the default branch of No pressure, just wanted to friendly ping since I don't have a great relationship with noisy warnings 😃. |
|
Hey David, have pushed 0.10.5 ... kept postponing as I promised some fixes but I just keep not getting at them 😿 |
|
That's great! Thanks for the heads up! |
|
Hi, just a heads-up that I still see this error in the master branch. I can confirm that I get clean builds after applying this diff. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I'm getting some warnings when using jruby that seem to come from jruby-openssl. I researched the errors and they seem to have been fixed recently in jruby-openssl's master, by the latest commit.
So I'd like to try it out and see if it fixes it.
So I run the following to try build the gem locally:
JAVA_OPTS=--illegal-access mvn package -Dmaven.test.skip=trueThis is the result I get
This is the error after enabling full debug logging:
I tired upgrading some stuff in
pom.xmllike this:but I still get the same errors.
My environment is the following:
The text was updated successfully, but these errors were encountered: