Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mixed precision output #211

Open
ilyes319 opened this issue Nov 4, 2023 · 0 comments
Open

Mixed precision output #211

ilyes319 opened this issue Nov 4, 2023 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@ilyes319
Copy link
Contributor

ilyes319 commented Nov 4, 2023

Is your feature request related to a problem? Please describe.
The sum over atoms after the readout to predict the total energy is now performed in float32 when the model precision is float32. This leads to a potential large accumulation of errors.

Describe the solution you'd like
Upcast the output to float64 before the sum, and use the E0 as float64 in order to save the most precision.

Describe alternatives you've considered
Using float64 for all the model but more expensive.

@ilyes319 ilyes319 self-assigned this Nov 4, 2023
@ilyes319 ilyes319 added the enhancement New feature or request label Nov 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant