Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

undefined calc in multi-head-finetune branch run_train.py #380

Open
bernstei opened this issue Apr 18, 2024 · 1 comment
Open

undefined calc in multi-head-finetune branch run_train.py #380

bernstei opened this issue Apr 18, 2024 · 1 comment

Comments

@bernstei
Copy link
Collaborator

In the multi-head-finetune branch, mace/cli/run_train.py line 432

if args.model == "MACE" and calc.models[0].__class__.__name__ == "MACE":
refers to a variable calc, but there are many code paths (various nested ifs around
calc = mace_mp(
) that don't define it

@bernstei
Copy link
Collaborator Author

bernstei commented Apr 18, 2024

I can work around it by checking if calc was defined as part of the test on line 432, but since I'm not sure why you added that test to the if statement, I don't know if that's actually correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant