Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error table sometimes missing stress/virial columns #395

Open
bernstei opened this issue Apr 26, 2024 · 1 comment
Open

error table sometimes missing stress/virial columns #395

bernstei opened this issue Apr 26, 2024 · 1 comment

Comments

@bernstei
Copy link
Collaborator

I'm no longer getting the stress column in my error table, even though I have stress_weight and stress_key. I also switched to loss="universal", so I wonder if that's the issue. In any case, it'd be nice to have that output back.

@bernstei
Copy link
Collaborator Author

bernstei commented May 6, 2024

Can we clean up the huge mess of model, loss, and error table, both in terms of including/not including terms (e.g. virials/stresses), and craziness of overriding the user's choice of MAE vs. RMS when you specify certain loss values?

Can we not just have the user specify the terms they want, and the functional form of the loss (e.g. conventional RMS vs. huber), and the error type, and have everything based on that, rather than an explicit list of particular combinations?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant