-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error reading 'extended' xyz format files #415
Comments
Hey @venkatkapil24, MACE can read extended xyz, but you need to rename the extension just |
That's essentially a bug, I'd argue. If anything, I'd say it should required ".extxyz"
|
I agree it should accept both .xyz and .extxyz |
I'm not even convinced it should check anything except, I guess, special-casing |
I agree. This will also help read directly from json. |
iff it's json that |
Describe the bug
MACE returns error for an ".extxyz" file.
Traceback (most recent call last):
File "/home/ucapvka/source/mace/scripts/run_train.py", line 6, in
main()
File "/lustre/home/ucapvka/mace-venv/lib/python3.9/site-packages/mace/cli/run_train.py", line 157, in main
assert args.train_file.endswith(".xyz"), "Must specify atomic_numbers when using .h5 train_file input"
AssertionError: Must specify atomic_numbers when using .h5 train_file input
Typically XYZ files do not include anything other than positions/velovities. On the other hand, the extended XYZ in ASE/libatoms '.extxyz' is the standard format. I think MACE should include it and not assume .h5. Again, happy to open a quick PR.
The text was updated successfully, but these errors were encountered: