Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove AprsIsConstants class #128

Open
2 tasks
CBielstein opened this issue Apr 22, 2022 · 0 comments
Open
2 tasks

Remove AprsIsConstants class #128

CBielstein opened this issue Apr 22, 2022 · 0 comments
Labels
code cleanliness Refactors, static analysis, etc. good first issue Good for newcomers

Comments

@CBielstein
Copy link
Owner

Description

Since the AprsIsConstants values are now only used in one place (the AprsSharp CLI command line flags setup), we should do away with the class of constants and just code them directly in to the CLI setup. This consolidates the logic to where it is actually used and avoids bloating code.

Acceptance Criteria

  • Delete AprsIsConstants class
  • Move hard coded constants directly to the AprsSharp Program.cs configuration of the command line parameters
@CBielstein CBielstein added good first issue Good for newcomers code cleanliness Refactors, static analysis, etc. labels Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code cleanliness Refactors, static analysis, etc. good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@CBielstein