Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidate FindCorrectYear, FindCorrectDayMonthAndYear, FindCorrectYearAndMonth #61

Open
CBielstein opened this issue Dec 29, 2020 · 0 comments
Open

Consolidate FindCorrectYear, FindCorrectDayMonthAndYear, FindCorrectYearAndMonth #61

CBielstein opened this issue Dec 29, 2020 · 0 comments
Labels
code cleanliness Refactors, static analysis, etc.
Milestone
Clean up and unif...

Comments

@CBielstein
Copy link
Owner

Timestamp has three methods that appear to do very similar work. Can they be consolidated somehow? Perhaps using optional parameters, etc. Those methods are FindCorrectYear, FindCorrectDayMonthAndYear, and FindCorrectYearAndMonth.

FindCorrectYear also does some weird...while(true) catch loop. Investigate if that can be replaced with a cleaner approach.
@CBielstein CBielstein added the code cleanliness Refactors, static analysis, etc. label Dec 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code cleanliness Refactors, static analysis, etc.
Projects
None yet
Milestone
Clean up and unify old code bases
Development

No branches or pull requests
1 participant
@CBielstein