Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packet.GetDataType does not support complex data types #67

Open
3 tasks
CBielstein opened this issue Feb 23, 2021 · 0 comments
Open
3 tasks

Packet.GetDataType does not support complex data types #67

CBielstein opened this issue Feb 23, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@CBielstein
Copy link
Owner

Description

While many APRS packet types are determined by their first character alone, some are more complex and can have ! or _ further in to the packet to change the type. Currently, the code responsible for detecting this (Packet.GetDataType) does not take these advanced considerations in to account and only uses the first character.

This should be corrected based on the APRS spec.

Acceptance Criteria

  • Handles weather type packets (which can have _ somewhere further in the packet to indicate weather)
  • Any reference to this issue are resolved in the code, either by remove test skips or handling caveats called out in comments
  • Tests added for other cases from APRS spec
@CBielstein CBielstein added enhancement New feature or request code cleanliness Refactors, static analysis, etc. labels Feb 23, 2021
@CBielstein CBielstein removed the code cleanliness Refactors, static analysis, etc. label Feb 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant