Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce disallowed comment characters across all types #90

Open
2 tasks
CBielstein opened this issue Jan 2, 2022 · 0 comments
Open
2 tasks

Enforce disallowed comment characters across all types #90

CBielstein opened this issue Jan 2, 2022 · 0 comments
Labels
bug Something isn't working code cleanliness Refactors, static analysis, etc. good first issue Good for newcomers
Milestone
Clean up and unif...

Comments

@CBielstein
Copy link
Owner

Description

Currently, only StatusInfo and MaidenheadBeaconInfo correctly enforce disallowed characters in an ARPS message comment (| or ~). This should be consistent across all packets which support a comment.

Acceptance Criteria

  • Check user-specified comments for disallowed characters across all packet types (consider not enforcing for decoded packets, just for sending)
  • Find a way to reduce duplication.
@CBielstein CBielstein added bug Something isn't working code cleanliness Refactors, static analysis, etc. labels Jan 2, 2022
@CBielstein CBielstein added the good first issue Good for newcomers label Jan 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working code cleanliness Refactors, static analysis, etc. good first issue Good for newcomers
Projects
None yet
Milestone
Clean up and unify old code bases
Development

No branches or pull requests
1 participant
@CBielstein