Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider removal of NMEA types #91

Open
CBielstein opened this issue Jan 2, 2022 · 0 comments
Open

Consider removal of NMEA types #91

CBielstein opened this issue Jan 2, 2022 · 0 comments
Labels
code cleanliness Refactors, static analysis, etc. good first issue Good for newcomers
Milestone
Clean up and unif...

Comments

@CBielstein
Copy link
Owner

Description

The APRS 1.01 spec describes raw GPS NMEA types. However, it's unclear to me at this moment if that is ever transmitted over the air in an unencoded way.

Given that this project is not desired to communicate directly with GPS devices at this time, we can consider removing the currently-unused NMEA code. This includes

  • NmeaType.cs
  • Relevant converter in EnumConversionExtensions.cs
  • NmeaTypeUnitTests.cs
@CBielstein CBielstein added the code cleanliness Refactors, static analysis, etc. label Jan 2, 2022
@CBielstein CBielstein added the good first issue Good for newcomers label Jan 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code cleanliness Refactors, static analysis, etc. good first issue Good for newcomers
Projects
None yet
Milestone
Clean up and unify old code bases
Development

No branches or pull requests
1 participant
@CBielstein