Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle parsing of symbol/icon information #95

Open
5 tasks
CBielstein opened this issue Jan 3, 2022 · 1 comment
Open
5 tasks

Handle parsing of symbol/icon information #95

CBielstein opened this issue Jan 3, 2022 · 1 comment
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@CBielstein
Copy link
Owner

Description

Currently, symbols are just kept as the table ID and symbol character on a position. Design a way to move that to some sort of enum or something for the icon being reported. e.g. "Person" or "Jeep" or whatever.

The Position object is probably the correct spot for that information to be encoded and decoded. If that's the case, it may be desirable to remove the public property of table and symbol and just expose the enum. That's up to the implementer and reviewers.

Acceptance Criteria

  • Add enum for APRS icons
  • Hook up encode/decode logic in the Position class
  • Expose on the Position class through a new property
  • Consider removing the table and symbol char properties as those are encoding details that most callers won't necessarily care about
  • Add tests!
@CBielstein CBielstein added enhancement New feature or request good first issue Good for newcomers labels Jan 3, 2022
@eddywine eddywine self-assigned this Feb 9, 2022
@CBielstein
Copy link
Owner Author

Here are the existing enum conversions for comparison. Something like one of these will likely be helpful. https://github.com/CBielstein/APRSsharp/blob/e25bd66e23d1d8f12b1bfabf3fe2569241cac850/src/AprsParser/Extensions/EnumConversionExtensions.cs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants