NEW : payment on several expense report (SQL integration) #24884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt_on_several_expense_report_sql
…nt_on_several_expense_report_sql
…nt_on_several_expense_report_sql
…nt_on_several_expense_report_sql
…nt_on_several_expense_report_sql
…nt_on_several_expense_report_sql
eldy
reviewed
Oct 12, 2023
| @@ -16,14 +17,14 @@ | |||
| -- | |||
| -- =================================================================== | |||
|
|
|||
| create table llx_payment_expensereport | |||
| create table llx_paymentuser | |||
There was a problem hiding this comment.
I suppose goal of renaming is to avoid confusion with the new intermediate table llx_payment_expense_report
This may have larger impact than just adding the new table.
So to make transition easier, i suggest to just use the name for the intermediate table (the one you called "llx_payment_expense_report"):
llx_expensereport_payment_expensereport
(meaning link between "expensereport" and "payment_expensereport")
eldy
added
the
PR to fix or conflict to solve
atm-adrien
removed
the
PR to fix or conflict to solve
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the following PR of this one : #23702