Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demonstrate best practices in the notebooks: @tf.function #2029

Open
st-- opened this issue Dec 8, 2022 · 0 comments
Open

Demonstrate best practices in the notebooks: @tf.function #2029

st-- opened this issue Dec 8, 2022 · 0 comments

Comments

@st--
Copy link
Member

st-- commented Dec 8, 2022

Documentation/tutorial notebooks

Are there any mistakes in the docs?
Some notebooks (e.g. https://gpflow.github.io/GPflow/develop/notebooks/advanced/natural_gradients.html, there may be more, I did not check extensively) do not use @tf.function when using a non-Scipy optimizer (our Scipy class automatically wraps the optimisation in tf.function by default). This is significantly slower in practice, and for any real data sets you would want to ensure the tf.function-precompilation. The notebooks should demonstrate this best practice, so users do not wonder why GPflow is so slow...

@st-- st-- changed the title Demonstrate best practices in the notebooks Demonstrate best practices in the notebooks: @tf.function Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant