Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework ROI detection #36

Open
Lyr3x opened this issue Sep 13, 2021 · 5 comments
Open

Rework ROI detection #36

Lyr3x opened this issue Sep 13, 2021 · 5 comments
Assignees
Labels
bug Something isn't working enhancement New feature or request help wanted Extra attention is needed
Milestone

Comments

@Lyr3x
Copy link
Owner

Lyr3x commented Sep 13, 2021

The ROI detection needs to be reworked. It should find the best ROI settings defined by distance and target surface size.

@Lyr3x Lyr3x added the enhancement New feature or request label Sep 13, 2021
@Lyr3x Lyr3x added this to the v1.3 milestone Sep 13, 2021
@Lyr3x Lyr3x added the bug Something isn't working label Sep 13, 2021
@Lyr3x
Copy link
Owner Author

Lyr3x commented Oct 6, 2021

I need to test this thoroughly. I am not sure right now if this will improve things or make them worse. From my latest findings I think the ROI size itself does not matter as much as the target surface material and sensor alignment.

@Lyr3x Lyr3x added the help wanted Extra attention is needed label Oct 11, 2021
@Lyr3x
Copy link
Owner Author

Lyr3x commented Oct 11, 2021

I will remove the rewrite from the v1.3 milestone and will only fix the current implementation. This topic needs further research and in depth testing with various feedback loops.

@Lyr3x Lyr3x removed this from the v1.3 milestone Oct 11, 2021
@Lyr3x
Copy link
Owner Author

Lyr3x commented Nov 17, 2021

I implemented a fairly simple change to produce one of the following ROIs

  • 4x8
  • 6x12
  • 8x16

I am not sure right now if that helps in all scenarios and I need to do more testing. Feedback is much appreciated!

@Lyr3x Lyr3x added this to the v1.3.4 milestone Nov 30, 2021
@Lyr3x
Copy link
Owner Author

Lyr3x commented Dec 3, 2021

ROI center settings must be reworked too as there are three different situations where the ROI center points need to be set. Currently the center is not working properly everywhere

@Lyr3x Lyr3x closed this as completed Dec 28, 2021
@Lyr3x Lyr3x reopened this Dec 28, 2021
@Lyr3x Lyr3x modified the milestones: v1.4.0, v.1.4.1 Dec 28, 2021
@CarsonF
Copy link
Collaborator

CarsonF commented Jan 1, 2022

New schema suggestion

cv.Optional("roi", default={"height": 16, "width": 6}): cv.Any(
    cv.one_of("auto"),  # formerly "roi calibration"
    cv.Schema({
        cv.Optional("height", default=16): cv.int_range(min=4, max=16),
        cv.Optional("width", default=6): cv.int_range(min=4, max=16),
    })
),

Maybe default switches to auto once the implementation is deemed better

@Lyr3x Lyr3x self-assigned this Jan 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants