Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve unet_simple #18

Closed
2 tasks done
Nelson-Gon opened this issue Jul 17, 2020 · 6 comments
Closed
2 tasks done

Improve unet_simple #18

Nelson-Gon opened this issue Jul 17, 2020 · 6 comments
Labels
beginner-friendly enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed priority:high

Comments

@Nelson-Gon
Copy link
Owner

Nelson-Gon commented Jul 17, 2020

Description

I would like to improve the initialization of unet_simple especially regarding making it similar to what the original paper proposed.

Similar Features

It is currently implemented in unet_simple

Feature Details

  • Improve upsampling

  • Review Downsampling

Proposed Implementation

None yet

Thank you

@Nelson-Gon Nelson-Gon added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers priority:high beginner-friendly labels Jul 17, 2020
Nelson-Gon added a commit that referenced this issue Jul 18, 2020
@Nelson-Gon Nelson-Gon pinned this issue Aug 5, 2020
@nirolada
Copy link
Contributor

What did the original paper propose?

@Nelson-Gon
Copy link
Owner Author

Nelson-Gon commented Feb 28, 2021

Hi,

In the original paper, the authors used 23 convolutional layers.

I think these may be too many for some datasets and it would be better to provide a way to customize the number of layers in the model to avoid overfitting.

The problem with unet_simple is that it does not accurately follow the downsample-upsample workflow.

The original architecture from the paper:

image

@nirolada
Copy link
Contributor

I think you might want to add an argument to the function for the conv depth.
def unet-simple(..., depth=3)
'depth' should range from 1 to 3 (representing the number of conv layers at each stage).
What do you think?

@Nelson-Gon
Copy link
Owner Author

Yes, this is in line what I had in mind. I was also planning to rewrite the whole unet method to move away from manually creating layers. In that case, unet_simple would not be needed at all. Instead, one would just define the target depth and this would be automatically built.

@nirolada
Copy link
Contributor

I will try to look into it soon. If I manage to build something, I will let you know. No need to assign me for now.

@nirolada
Copy link
Contributor

nirolada commented Mar 3, 2021

Assign it to me, I'll be finished soon.

@nirolada nirolada removed their assignment Apr 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginner-friendly enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed priority:high
Projects
None yet
Development

No branches or pull requests

2 participants